From 691cd287ba7457aa4fdae100620f2ca8f11400ed Mon Sep 17 00:00:00 2001 From: Rodolfo Alonso Hernandez Date: Wed, 26 Sep 2018 16:11:55 +0100 Subject: [PATCH] PlacementAPIClient.update_resource_class client call missing argument "PlacementAPIClient.update_resource_class" is calling Placement client "put" method with a missing argument, "data". In this call, "data" should be None [1], but it's a positional argument and must be passed. [1] https://github.com/openstack/nova/blob/master/nova/api/openstack/placement/microversion.py#L41 Change-Id: Iedcad7c81a913923506bed2762b60b094f2d601d Closes-Bug: #1794545 --- neutron_lib/placement/client.py | 2 +- neutron_lib/tests/unit/placement/test_client.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/neutron_lib/placement/client.py b/neutron_lib/placement/client.py index 790c312a3..e437cbd9f 100644 --- a/neutron_lib/placement/client.py +++ b/neutron_lib/placement/client.py @@ -561,7 +561,7 @@ class PlacementAPIClient(object): :param name: the name of the resource class to be updated or validated """ url = '/resource_classes/%s' % name - self._put(url) + self._put(url, None) @_check_placement_api_available def delete_resource_class(self, name): diff --git a/neutron_lib/tests/unit/placement/test_client.py b/neutron_lib/tests/unit/placement/test_client.py index cc479124e..a75e4cb71 100644 --- a/neutron_lib/tests/unit/placement/test_client.py +++ b/neutron_lib/tests/unit/placement/test_client.py @@ -424,7 +424,7 @@ class TestPlacementAPIClient(base.BaseTestCase): def test_update_resource_class(self): self.placement_api_client.update_resource_class(RESOURCE_CLASS_NAME) self.placement_fixture.mock_put.assert_called_once_with( - '/resource_classes/%s' % RESOURCE_CLASS_NAME) + '/resource_classes/%s' % RESOURCE_CLASS_NAME, None) def test_delete_resource_class(self): self.placement_api_client.delete_resource_class(RESOURCE_CLASS_NAME)