openstack
/
neutron-vpnaas
Code Issues Proposed changes

Remove all_routers argument from _process_routers 

There is no code left that passes True to this argument.  It is dead
code and it should be removed.

Change-Id: I55f71a5c0b96e530e45f2a6463978e8611cbc537
This commit is contained in:
Carl Baldwin 2014-10-02 17:02:59 +00:00
parent d5024b4da3
commit 21d931fc16
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
neutron/services/vpn/agent.py
View File

@ -130,13 +130,13 @@ class VPNAgent(l3_agent.L3NATAgentWithStateReport):
for device in self.devices:
device.destroy_router(router_id)
def _process_routers(self, routers, all_routers=False):
def _process_routers(self, routers):
"""Router sync event.
This method overwrites parent class method.
:param routers: list of routers
"""
super(VPNAgent, self)._process_routers(routers, all_routers)
super(VPNAgent, self)._process_routers(routers)
for device in self.devices:
device.sync(self.context, routers)

2
neutron/tests/unit/services/vpn/test_vpn_agent.py
View File

@ -193,5 +193,5 @@ class TestVPNAgent(base.BaseTestCase):
device = mock.Mock()
self.agent.devices = [device]
self.agent._process_routers(routers, False)
self.agent._process_routers(routers)
device.sync.assert_called_once_with(mock.ANY, routers)