openstack
/
neutron-vpnaas
Code Issues Proposed changes

Update patch set 5 

Patch Set 5:

(1 comment)

Patch-set: 5
Reviewer: Gerrit User 8313 <8313@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Reviewer: Gerrit User 11221 <11221@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Attention: {"person_ident":"Gerrit User 1004 \u003c1004@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_32755\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 31976 \u003c31976@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_32755\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 8313 \u003c8313@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_32755\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 11221 \u003c11221@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_32755\u003e replied on the change"}
This commit is contained in:
Gerrit User 32755 2024-02-12 16:58:50 +00:00 committed by Gerrit Code Review
parent 5bc2b24cef
commit 810a3fea8b
1 changed files with 21 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
b89ecaee2b7f3634cf54dee4d67df99a4a1b2593 Normal file
View File

@ -0,0 +1,21 @@
{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "d11351c2_6be4b05d",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 5
},
"lineNbr": 0,
"author": {
"id": 32755
},
"writtenOn": "2024-02-12T16:58:50Z",
"side": 1,
"message": "Sorry guys for the delay. We now revisited this patch again and rebased it to the current master while (hopefully) fixing all of the tests. Especially them tests were a little challenging, as \"Router\" and \"RouterInfo\" objects are seemingly used with little relation to their variables names. The lack of type annotations also contributed.\n\nIn any case, we tried to give this a good shot again and would appreciate your kind review time and input.",
"revId": "b89ecaee2b7f3634cf54dee4d67df99a4a1b2593",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}