openstack
/
neutron-vpnaas
Code Issues Proposed changes

Update patch set 2 

Patch Set 2: Code-Review-1

(1 comment)

Patch-set: 2
Reviewer: Gerrit User 8313 <8313@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1, 9ba7ca813447c4fd4e20ed0bdc69a80b8541abd7
Attention: {"person_ident":"Gerrit User 31976 \u003c31976@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_8313\u003e replied on the change"}
This commit is contained in:
Gerrit User 8313 2024-01-24 16:23:08 +00:00 committed by Gerrit Code Review
parent 7f4927e811
commit 9111045659
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
256464aea691f8b4957ba668a117963353f34e4c
View File

@ -16,6 +16,24 @@
"message": "I don\u0027t think removing it here is enough. Maybe there should be a DB migration too. And it should be removed from the API definition in neutron-lib (neutron_lib/api/definitions/vpn.py VPN_SUPPORTED_DPD_ACTIONS).",
"revId": "256464aea691f8b4957ba668a117963353f34e4c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "d6792ada_cb0c10fc",
"filename": "neutron_vpnaas/db/vpn/vpn_models.py",
"patchSetId": 2
},
"lineNbr": 108,
"author": {
"id": 8313
},
"writtenOn": "2024-01-24T16:23:08Z",
"side": 0,
"message": "+1\nhttps://opendev.org/openstack/neutron-lib/src/branch/master/neutron_lib/api/definitions/vpn.py#L93 should be removed than",
"parentUuid": "edda46a8_8ab91d3e",
"revId": "256464aea691f8b4957ba668a117963353f34e4c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}