openstack
/
neutron
Code Issues Proposed changes

Merge "Create temp file in setUp() to avoid warning"

This commit is contained in:
Zuul 2018-10-03 19:00:54 +00:00 committed by Gerrit Code Review
parent cf463cce43 bb7b5a1e81
commit 0678e48b6b
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
neutron/tests/unit/agent/linux/test_daemon.py
View File

@ -35,13 +35,15 @@ class FakeEntry(object):
class TestUnwatchLog(base.BaseTestCase):
def setUp(self):
super(TestUnwatchLog, self).setUp()
self.temp_file = self.get_temp_file_path('unwatch_log_temp_file')
def test_unwatch_log(self):
temp_file_name = self.get_temp_file_path('unwatch_log_temp_file_name')
stream_handler = logging.StreamHandler()
logger = logging.Logger('fake')
logger.addHandler(stream_handler)
logger.addHandler(handlers.WatchedFileHandler(temp_file_name))
logger.addHandler(handlers.WatchedFileHandler(self.temp_file))
with mock.patch('logging.getLogger', return_value=logger):
daemon.unwatch_log()
@ -49,7 +51,7 @@ class TestUnwatchLog(base.BaseTestCase):
logger.handlers.remove(stream_handler)
observed = logger.handlers[0]
self.assertEqual(logging.FileHandler, type(observed))
self.assertEqual(temp_file_name, observed.baseFilename)
self.assertEqual(self.temp_file, observed.baseFilename)
class TestPrivileges(base.BaseTestCase):