openstack
/
neutron
Code Issues Proposed changes

ovn: Don't override idl lookup() method with timeout 

The timeout and notify_handler parameters are removed in ovsdbapp [1]
because they have never really been used and if we tried to use it, it
caused lots of various issues bringing low benefit. We often call
lookup() on non-existing objects and adding 2 seconds wait interval has
terrible effect on performance.

[1] https://review.opendev.org/c/openstack/ovsdbapp/+/835151

Change-Id: I5f22ecfe723e8710ff62e7e1a006e534ccc93919
Signed-off-by: Jakub Libosvar <libosvar@redhat.com>
This commit is contained in:
Jakub Libosvar 2022-03-29 16:19:40 -04:00
parent a903fd20ef
commit 10250fa6d8
1 changed files with 0 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/impl_idl_ovn.py
View File

@ -43,7 +43,6 @@ from neutron.services.portforwarding import constants as pf_const
LOG = log.getLogger(__name__)
DEFAULT_LOOKUP_TIMEOUT = 2
# Override wait_for_change to not use a timeout so we always try to reconnect
@ -202,11 +201,6 @@ class Backend(ovs_idl.Backend):
% {'match': match, 'column': column, 'table': table})
raise RuntimeError(msg)
def lookup(self, table, record, default=ovs_idl._NO_DEFAULT,
timeout=DEFAULT_LOOKUP_TIMEOUT, notify_handler=None):
return super().lookup(table, record, default=default, timeout=timeout,
notify_handler=notify_handler)
class OvsdbConnectionUnavailable(n_exc.ServiceUnavailable):
message = _("OVS database connection to %(db_schema)s failed with error: "