From 1a3cd5bae51c317894a81ad4f1d187c42f786a77 Mon Sep 17 00:00:00 2001 From: Jakub Libosvar Date: Wed, 3 May 2017 09:00:14 +0000 Subject: [PATCH] tempest: Obey ssh_timeout config option The patch creates a new in-tree class that overrides default value for tempest ssh.Client to the one defined by ssh_timeout config option. Change-Id: I418519866e3cbd486fe0ffec23e1553ea0891420 --- neutron/tests/tempest/common/ssh.py | 24 +++++++++++++++++++ neutron/tests/tempest/scenario/base.py | 2 +- .../tests/tempest/scenario/test_floatingip.py | 2 +- neutron/tests/tempest/scenario/test_qos.py | 2 +- neutron/tests/tempest/scenario/test_trunk.py | 2 +- 5 files changed, 28 insertions(+), 4 deletions(-) create mode 100644 neutron/tests/tempest/common/ssh.py diff --git a/neutron/tests/tempest/common/ssh.py b/neutron/tests/tempest/common/ssh.py new file mode 100644 index 00000000000..095a12de391 --- /dev/null +++ b/neutron/tests/tempest/common/ssh.py @@ -0,0 +1,24 @@ +# All Rights Reserved. +# +# Licensed under the Apache License, Version 2.0 (the "License"); you may +# not use this file except in compliance with the License. You may obtain +# a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT +# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the +# License for the specific language governing permissions and limitations +# under the License. + +from tempest.lib.common import ssh + +from neutron.tests.tempest import config + + +class Client(ssh.Client): + def __init__(self, *args, **kwargs): + if 'timeout' not in kwargs: + kwargs['timeout'] = config.CONF.validation.ssh_timeout + super(Client, self).__init__(*args, **kwargs) diff --git a/neutron/tests/tempest/scenario/base.py b/neutron/tests/tempest/scenario/base.py index 62feebd72db..967a45e23b9 100644 --- a/neutron/tests/tempest/scenario/base.py +++ b/neutron/tests/tempest/scenario/base.py @@ -17,12 +17,12 @@ import netaddr from oslo_log import log from tempest.common import waiters -from tempest.lib.common import ssh from tempest.lib.common.utils import data_utils from tempest.lib.common.utils import test_utils from tempest.lib import exceptions as lib_exc from neutron.tests.tempest.api import base as base_api +from neutron.tests.tempest.common import ssh from neutron.tests.tempest import config from neutron.tests.tempest.scenario import constants diff --git a/neutron/tests/tempest/scenario/test_floatingip.py b/neutron/tests/tempest/scenario/test_floatingip.py index 06f495da18b..d4ad72ab7d4 100644 --- a/neutron/tests/tempest/scenario/test_floatingip.py +++ b/neutron/tests/tempest/scenario/test_floatingip.py @@ -15,12 +15,12 @@ import netaddr from tempest.common import waiters -from tempest.lib.common import ssh from tempest.lib.common.utils import data_utils from tempest.lib import decorators from tempest import test import testscenarios +from neutron.tests.tempest.common import ssh from neutron.tests.tempest import config from neutron.tests.tempest.scenario import base from neutron.tests.tempest.scenario import constants diff --git a/neutron/tests/tempest/scenario/test_qos.py b/neutron/tests/tempest/scenario/test_qos.py index b79faf8e12c..c4d22cdfae4 100644 --- a/neutron/tests/tempest/scenario/test_qos.py +++ b/neutron/tests/tempest/scenario/test_qos.py @@ -17,7 +17,6 @@ import socket import time from oslo_log import log as logging -from tempest.lib.common import ssh from tempest.lib import decorators from tempest.lib import exceptions from tempest import test @@ -26,6 +25,7 @@ import testtools from neutron.common import utils from neutron.services.qos import qos_consts from neutron.tests.tempest.api import base as base_api +from neutron.tests.tempest.common import ssh from neutron.tests.tempest import config from neutron.tests.tempest.scenario import base from neutron.tests.tempest.scenario import constants diff --git a/neutron/tests/tempest/scenario/test_trunk.py b/neutron/tests/tempest/scenario/test_trunk.py index 112c17b27e8..122068c8e82 100644 --- a/neutron/tests/tempest/scenario/test_trunk.py +++ b/neutron/tests/tempest/scenario/test_trunk.py @@ -15,12 +15,12 @@ import netaddr from oslo_log import log as logging from tempest.common import waiters -from tempest.lib.common import ssh from tempest.lib.common.utils import data_utils from tempest.lib import decorators from tempest import test from neutron.common import utils +from neutron.tests.tempest.common import ssh from neutron.tests.tempest import config from neutron.tests.tempest.scenario import base from neutron.tests.tempest.scenario import constants