From 9f6a4ceecfef858f503df3f63de4f945374eee4f Mon Sep 17 00:00:00 2001 From: Hongbin Lu Date: Fri, 15 Jun 2018 15:12:10 +0000 Subject: [PATCH] Remove the unit test 'test_ports_vnic_type_list' This test created three ports and tried to list and filter those ports by their vnic type. However, the current implementation doesn't support filter by vnic type. The test passed is a false positive because neutron ignored the invalid filter and returned all the ports which happened to be those three ports. This patch remove this invalid test case. Change-Id: I4397df1c35463a8b532afdc9c5d28b37224a37b4 Related-Bug: #1749820 --- .../tests/unit/_test_extension_portbindings.py | 15 --------------- 1 file changed, 15 deletions(-) diff --git a/neutron/tests/unit/_test_extension_portbindings.py b/neutron/tests/unit/_test_extension_portbindings.py index e799f3a68aa..ab0914b72d8 100644 --- a/neutron/tests/unit/_test_extension_portbindings.py +++ b/neutron/tests/unit/_test_extension_portbindings.py @@ -345,18 +345,3 @@ class PortBindingsVnicTestCaseMixin(object): self.assertEqual(2, len(ports)) for non_admin_port in ports: self._check_response_portbindings_vnic_type(non_admin_port) - - def test_ports_vnic_type_list(self): - cfg.CONF.set_default('allow_overlapping_ips', True) - vnic_arg = {portbindings.VNIC_TYPE: self.vnic_type} - with self.port(name='name1', - arg_list=(portbindings.VNIC_TYPE,), - **vnic_arg) as port1,\ - self.port(name='name2') as port2,\ - self.port(name='name3', - arg_list=(portbindings.VNIC_TYPE,), - **vnic_arg) as port3: - self._test_list_resources( - 'port', (port1, port2, port3), - query_params='%s=%s' % (portbindings.VNIC_TYPE, - self.vnic_type))