From f18c5426b090c6bcc3f46f8969eaaa7acf956203 Mon Sep 17 00:00:00 2001 From: Terry Wilson Date: Wed, 26 Jul 2023 09:10:12 -0500 Subject: [PATCH] Add note to avoid version checks in sanity checks Change-Id: I71be7929a3ed9c0bcec350a35f054b8faddbeea7 --- neutron/cmd/sanity/checks.py | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/neutron/cmd/sanity/checks.py b/neutron/cmd/sanity/checks.py index 6ab2f42b0f9..4a7fa4893ae 100644 --- a/neutron/cmd/sanity/checks.py +++ b/neutron/cmd/sanity/checks.py @@ -43,6 +43,15 @@ from neutron.privileged.agent.linux import dhcp as priv_dhcp LOG = logging.getLogger(__name__) +# PLEASE DO NOT ADD NEW VERSION CHECK TESTS. The entire point of the sanity +# check system is to avoid doing version number checking since different +# distros may backport fixes/features to different versioned releases and they +# are not a reliable way to test for features/bugs. Please write sanity checks +# that actually test for the usage of the feature in combination with it being +# configured to use on the running system (e.g. via a config option). + +# TODO(twilson) Remove/rework tests that check version numbers into more +# generic tests of features. MINIMUM_DNSMASQ_VERSION = '2.67' DNSMASQ_VERSION_DHCP_RELEASE6 = '2.76' DNSMASQ_VERSION_HOST_ADDR6_LIST = '2.81'