Update patch set 2

Patch Set 2:

(2 comments)

Patch-set: 2

46e3a675903174c7daebc430039214311910d318

@@ -64,6 +64,23 @@
       "revId": "46e3a675903174c7daebc430039214311910d318",
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
     },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "b72faddc_498b26b2",
+        "filename": "specs/2024.2/approved/libvirt-spice-direct-consoles.rst",
+        "patchSetId": 2
+      },
+      "lineNbr": 86,
+      "author": {
+        "id": 11604
+      },
+      "writtenOn": "2024-04-12T11:38:43Z",
+      "side": 1,
+      "message": "this is pretty light on the libvirt dirver changes that are needed by the way.\n\nwe should detail what chnages will be required for the xml generation and what feature sets you plan to enabled.\n\naudio, usb passhtough, clipboard ectra",
+      "revId": "46e3a675903174c7daebc430039214311910d318",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
     {
       "unresolved": true,
       "key": {
@@ -275,6 +292,23 @@
       "parentUuid": "60a2c15a_bb724d91",
       "revId": "46e3a675903174c7daebc430039214311910d318",
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "1b158abf_0d8f9bd9",
+        "filename": "specs/2024.2/approved/libvirt-spice-direct-consoles.rst",
+        "patchSetId": 2
+      },
+      "lineNbr": 320,
+      "author": {
+        "id": 11604
+      },
+      "writtenOn": "2024-04-12T11:38:43Z",
+      "side": 1,
+      "message": "i would likely want to see one of our jobs reconfigured to run with spice-direct and kerbside.\nthat would invovle writhing a devstack plugin to support confiuring this\n\nnova recently gained a minimal plugin so if you didnt add this to the kerside repo which would be my prefernce we could add it to nova\u0027s plugin or to core devstack depending on how inovled it is.\n\nwe generally do not deploy horizon but we do deploy with novnc i belive and we have tempest test for that.\n\nim not sure if we should require tempest coverage here or not but im incliend to say we should.\n\na very basic test to just create a spice direct console and perhaps use nc to connect to it is proably approrate to add.\n\n\nwe do have exsiting tempest console tests that basically do that.\nbaiscally like this https://github.com/openstack/tempest/blob/c0da6e843a74c2392c8e87e8ff36d2fea12949c4/tempest/api/compute/servers/test_server_actions.py#L764-L778\nor this\nhttps://github.com/openstack/tempest/blob/c0da6e843a74c2392c8e87e8ff36d2fea12949c4/tempest/tests/lib/services/compute/test_servers_client.py#L1047-L1061\n\nso if we proceed with this i would hope we can extend tempest to \njust conenct to the url to ensure that its accessable as a client.\nwe dont need to connect as a spcie client jsut make sure the kerbside proxy is \n\nwe would likely need at least functional test coverage in the absence of tempest.",
+      "revId": "46e3a675903174c7daebc430039214311910d318",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
     }
   ]
 }