Update patch set 2

Patch Set 2:

(2 comments)

Patch-set: 2
Attention: {"person_ident":"Gerrit User 2271 \u003c2271@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_11604\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 11604 \u003c11604@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_11604\u003e replied on the change"}
This commit is contained in:
Gerrit User 11604 2024-04-08 13:13:06 +00:00 committed by Gerrit Code Review
parent b841dd8c39
commit b9905a3c1e
1 changed files with 36 additions and 0 deletions

View File

@ -35,6 +35,24 @@
"revId": "46e3a675903174c7daebc430039214311910d318",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "0c7a5943_b91efba3",
"filename": "specs/2024.2/approved/libvirt-spice-direct-consoles.rst",
"patchSetId": 2
},
"lineNbr": 95,
"author": {
"id": 11604
},
"writtenOn": "2024-04-08T13:13:06Z",
"side": 1,
"message": "if we actully will requrie a spice native proxy and the url we retrun at the api level is to that proxy then that is fine\n\nwhat i want to ensure is that as an end user we dont get the connection information for the qemu vm as a normal user.",
"parentUuid": "251c5593_601a40e8",
"revId": "46e3a675903174c7daebc430039214311910d318",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -69,6 +87,24 @@
"parentUuid": "577b7090_966607bf",
"revId": "46e3a675903174c7daebc430039214311910d318",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "21aff7d3_30dbddbb",
"filename": "specs/2024.2/approved/libvirt-spice-direct-consoles.rst",
"patchSetId": 2
},
"lineNbr": 221,
"author": {
"id": 11604
},
"writtenOn": "2024-04-08T13:13:06Z",
"side": 1,
"message": "im not against it entirly i actully would love to be ablel to use remmina or similar to connect to our vms over vnc spice whatever.\n\nso i would like to find a way to have a protocol native proxy that could be used to expose the vm console more directly so you can use a native client via the proxy to connect to the hypervior.\n\ni just dont thnk we sould supprot a direct connect form the client to qemu without an intermideary like a native spice proxy server.\n\nthats just my perspective however. \nif other are ok with a driect connect provide its not enabled by default(i.e. opt in by the adminsisrator of the cloud)\ni can be conviced that we coudl supprot this\n\neither with a new console type or a new sub filed which we could bike shed the name/sematics of later.\n\ni just want to make sure that any solution we proceedd with woudl work equally well for a public cloud as it would for a private one.\n\ni dont think we should have any api that can only be safely used in a private cloud where you can trust your users to be able to connect to the hypervior network driectly.\n\nwe should ensure this would be safe to expose to a public wan. at least that is the design critia i am thinking about primarly when pushhing back currently.",
"parentUuid": "f056613b_e71fabf2",
"revId": "46e3a675903174c7daebc430039214311910d318",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}