diff --git a/.mailmap b/.mailmap index 38783c9f3bc2..0a4ed2432ac5 100644 --- a/.mailmap +++ b/.mailmap @@ -80,3 +80,4 @@ + diff --git a/Authors b/Authors index b050b1b22080..a0a682b7f76d 100644 --- a/Authors +++ b/Authors @@ -101,7 +101,7 @@ John Dewey John Garbutt John Griffith John Kennedy -John Tran +John Tran Jonathan Bryce Jordan Rinke Joseph Suh diff --git a/nova/db/sqlalchemy/api.py b/nova/db/sqlalchemy/api.py index affaa86f6124..55eec9ec9b90 100644 --- a/nova/db/sqlalchemy/api.py +++ b/nova/db/sqlalchemy/api.py @@ -1047,7 +1047,7 @@ def fixed_ip_get_all(context, session=None): @require_context def fixed_ip_get_by_address(context, address, session=None): result = model_query(context, models.FixedIp, session=session, - read_deleted="yes").\ + read_deleted=context.read_deleted).\ filter_by(address=address).\ first() if not result: diff --git a/nova/tests/test_db_api.py b/nova/tests/test_db_api.py index 28f35589f594..078b6b500684 100644 --- a/nova/tests/test_db_api.py +++ b/nova/tests/test_db_api.py @@ -151,6 +151,8 @@ class DbApiTestCase(test.TestCase): db.network_delete_safe, ctxt, network['id']) db.fixed_ip_update(ctxt, address2, {'allocated': False}) network = db.network_delete_safe(ctxt, network['id']) + self.assertRaises(exception.FixedIpNotFoundForAddress, + db.fixed_ip_get_by_address, ctxt, address1) ctxt = ctxt.elevated(read_deleted='yes') fixed_ip = db.fixed_ip_get_by_address(ctxt, address1) self.assertTrue(fixed_ip['deleted'])