diff --git a/nova/api/openstack/compute/servers.py b/nova/api/openstack/compute/servers.py index 95e32cc545bc..37bd1ff60126 100644 --- a/nova/api/openstack/compute/servers.py +++ b/nova/api/openstack/compute/servers.py @@ -389,14 +389,9 @@ class ServersController(wsgi.Controller): :raises: webob.exc.HTTPBadRequest if validation fails """ if not uuidutils.is_uuid_like(net_id): - # NOTE(mriedem): Neutron would allow a network id with a br- prefix - # back in Folsom so continue to honor that. - # TODO(mriedem): Need to figure out if this is still a valid case. - br_uuid = net_id.split('-', 1)[-1] - if not uuidutils.is_uuid_like(br_uuid): - msg = _("Bad networks format: network uuid is " - "not in proper format (%s)") % net_id - raise exc.HTTPBadRequest(explanation=msg) + msg = _("Bad networks format: network uuid is " + "not in proper format (%s)") % net_id + raise exc.HTTPBadRequest(explanation=msg) # duplicate networks are allowed only for neutron v2.0 if net_id in network_uuids and not utils.is_neutron(): diff --git a/nova/tests/unit/api/openstack/compute/test_serversV21.py b/nova/tests/unit/api/openstack/compute/test_serversV21.py index 70f3e9a2f2ef..5475c9f954eb 100644 --- a/nova/tests/unit/api/openstack/compute/test_serversV21.py +++ b/nova/tests/unit/api/openstack/compute/test_serversV21.py @@ -302,11 +302,17 @@ class ServersControllerTest(ControllerTest): self.assertIsNotNone(ctxt.db_connection) def test_requested_networks_prefix(self): + """Tests that we no longer support the legacy br- format for + a network id. + """ self.flags(use_neutron=True) uuid = 'br-00000000-0000-0000-0000-000000000000' requested_networks = [{'uuid': uuid}] - res = self.controller._get_requested_networks(requested_networks) - self.assertIn((uuid, None, None, None), res.as_tuples()) + ex = self.assertRaises(webob.exc.HTTPBadRequest, + self.controller._get_requested_networks, + requested_networks) + self.assertIn('Bad networks format: network uuid is not in proper ' + 'format', six.text_type(ex)) def test_requested_networks_neutronv2_enabled_with_port(self): self.flags(use_neutron=True)