Remove security_group-related methods from VirtAPI

This patch removes the no-longer-needed security_group-related
methods from VirtAPI.

Related to blueprint compute-manager-objects
Related to blueprint virt-objects

Change-Id: I0326f25754e7a13dfc18f207242052412189c743

nova/compute/manager.py

@@ -388,16 +388,6 @@ class ComputeVirtAPI(virtapi.VirtAPI):
                                               instance_uuid,
                                               **updates)
 
-    def security_group_get_by_instance(self, context, instance):
-        return self._compute.conductor_api.security_group_get_by_instance(
-            context, instance)
-
-    def security_group_rule_get_by_security_group(self, context,
-                                                  security_group):
-        return (self._compute.conductor_api.
-                security_group_rule_get_by_security_group(context,
-                                                          security_group))
-
     def provider_fw_rule_get_all(self, context):
         return self._compute.conductor_api.provider_fw_rule_get_all(context)
 

nova/tests/compute/test_virtapi.py

@@ -45,14 +45,6 @@ class VirtAPIBaseTest(test.NoDBTestCase, test.APICoverage):
         self.assertExpected('instance_update', 'fake-uuid',
                             dict(host='foohost'))
 
-    def test_security_group_get_by_instance(self):
-        self.assertExpected('security_group_get_by_instance',
-                            {'uuid': 'fake-id'})
-
-    def test_security_group_rule_get_by_security_group(self):
-        self.assertExpected('security_group_rule_get_by_security_group',
-                            {'id': 'fake-id'})
-
     def test_provider_fw_rule_get_all(self):
         self.assertExpected('provider_fw_rule_get_all')
 

nova/virt/fake.py

@@ -457,14 +457,6 @@ class FakeVirtAPI(virtapi.VirtAPI):
                                                    instance_uuid,
                                                    updates)
 
-    def security_group_get_by_instance(self, context, instance):
-        return db.security_group_get_by_instance(context, instance['uuid'])
-
-    def security_group_rule_get_by_security_group(self, context,
-                                                  security_group):
-        return db.security_group_rule_get_by_security_group(
-            context, security_group['id'])
-
     def provider_fw_rule_get_all(self, context):
         return db.provider_fw_rule_get_all(context)
 

nova/virt/virtapi.py

@@ -26,22 +26,6 @@ class VirtAPI(object):
         """
         raise NotImplementedError()
 
-    def security_group_get_by_instance(self, context, instance):
-        """Get the security group for a specified instance
-        :param context: security context
-        :param instance: instance defining the security group we want
-        """
-        raise NotImplementedError()
-
-    def security_group_rule_get_by_security_group(self, context,
-                                                  security_group):
-        """Get the rules associated with a specified security group
-        :param context: security context
-        :param security_group: the security group for which the rules
-                               should be returned
-        """
-        raise NotImplementedError()
-
     def provider_fw_rule_get_all(self, context):
         """Get the provider firewall rules
         :param context: security context