openstack
/
nova
Code Issues Proposed changes

Fix comment in test_attach_with_multiattach_fails_not_available 

The docstring in the test is no longer valid since the compute
RPC API client reserve_block_device_name method no longer raises
MultiattachSupportNotYetAvailable since change
Ibcb6bf912b3fb69c8631665fef2832906ba338aa in Rocky.

The cells v1 API _attach_volume method still raises that exception
though so the docstring on the test is updated.

Change-Id: I170e30c501875140694e3becb2be0bf2c8618705
This commit is contained in:
Matt Riedemann 2019-04-02 15:47:17 -04:00
parent b23ca42c71
commit 4bac4ff04b
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
nova/tests/unit/api/openstack/compute/test_volumes.py
View File

@ -926,9 +926,8 @@ class VolumeAttachTestsV260(test.NoDBTestCase):
def test_attach_with_multiattach_fails_not_available(self):
"""Tests the case that the user tries to attach with a
multiattach volume but before the compute hosting the instance
is upgraded. This would come from reserve_block_device_name in
the compute RPC API client.
multiattach volume on cells v1 where multiattach volumes are
not supported.
"""
with mock.patch.object(
self.controller.compute_api, 'attach_volume',