openstack
/
nova
Code Issues Proposed changes

Pin pep8 to 1.3.3 

Apart of making pep8 version standard across all openstack
projects.

With this change we ignore E712 since it is normal to use
"column == True" in sqlalchemy.

Change-Id: I73a162847a79558cb158112878033edf18039805
Signed-off-by: Chuck Short <chuck.short@canonical.com>
This commit is contained in:
Chuck Short 2012-11-19 19:31:12 -06:00
parent 98032e804a
commit 560e5cd84e
3 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
run_tests.sh
View File

@ -128,7 +128,7 @@ function run_pep8 {
srcfiles+=" setup.py" srcfiles+=" setup.py"
# Until all these issues get fixed, ignore. # Until all these issues get fixed, ignore.
ignore='--ignore=N4,E12,E711,E721' ignore='--ignore=N4,E12,E711,E721,E712'
${wrapper} python tools/hacking.py ${ignore} ${srcfiles} ${wrapper} python tools/hacking.py ${ignore} ${srcfiles}

2
tools/test-requires
View File

@ -8,7 +8,7 @@ nose
testtools testtools
openstack.nose_plugin>=0.7 openstack.nose_plugin>=0.7
nosehtmloutput nosehtmloutput
pep8==1.2 pep8==1.3.3
pylint==0.25.2 pylint==0.25.2
sphinx>=1.1.2 sphinx>=1.1.2
feedparser feedparser

6
tox.ini
View File

@ -22,11 +22,11 @@ sitepackages = True
downloadcache = ~/cache/pip downloadcache = ~/cache/pip
[testenv:pep8] [testenv:pep8]
deps=pep8==1.2 deps=pep8==1.3.3
commands = commands =
python tools/hacking.py --ignore=N4,E12,E711,E721 --repeat --show-source \ python tools/hacking.py --ignore=N4,E12,E711,E721,E712 --repeat --show-source \
--exclude=.venv,.tox,dist,doc,*openstack/common*,*lib/python*,*egg . --exclude=.venv,.tox,dist,doc,*openstack/common*,*lib/python*,*egg .
python tools/hacking.py --ignore=N4,E12,E711,E721 --repeat --show-source \ python tools/hacking.py --ignore=N4,E12,E711,E721,E712 --repeat --show-source \
--filename=nova* bin --filename=nova* bin
[testenv:pylint] [testenv:pylint]