diff --git a/nova/tests/unit/api/openstack/compute/test_migrations.py b/nova/tests/unit/api/openstack/compute/test_migrations.py index 843b8965d8f9..edd1197a75ad 100644 --- a/nova/tests/unit/api/openstack/compute/test_migrations.py +++ b/nova/tests/unit/api/openstack/compute/test_migrations.py @@ -504,36 +504,3 @@ class MigrationsTestCaseV280(MigrationTestCaseV266): self.controller.index, req) self.assertIn('Additional properties are not allowed', six.text_type(ex)) - - -class MigrationsPolicyEnforcement(test.NoDBTestCase): - def setUp(self): - super(MigrationsPolicyEnforcement, self).setUp() - self.controller = migrations_v21.MigrationsController() - self.req = fakes.HTTPRequest.blank('') - - def test_list_policy_failed(self): - rule_name = "os_compute_api:os-migrations:index" - self.policy.set_rules({rule_name: "project_id:non_fake"}) - exc = self.assertRaises( - exception.PolicyNotAuthorized, - self.controller.index, self.req) - self.assertEqual( - "Policy doesn't allow %s to be performed." % rule_name, - exc.format_message()) - - -class MigrationsPolicyEnforcementV223(MigrationsPolicyEnforcement): - wsgi_api_version = '2.23' - - def setUp(self): - super(MigrationsPolicyEnforcementV223, self).setUp() - self.req = fakes.HTTPRequest.blank('', version=self.wsgi_api_version) - - -class MigrationsPolicyEnforcementV259(MigrationsPolicyEnforcementV223): - wsgi_api_version = '2.59' - - -class MigrationsPolicyEnforcementV280(MigrationsPolicyEnforcementV259): - wsgi_api_version = '2.80' diff --git a/nova/tests/unit/policies/test_migrations.py b/nova/tests/unit/policies/test_migrations.py new file mode 100644 index 000000000000..b26306f7873b --- /dev/null +++ b/nova/tests/unit/policies/test_migrations.py @@ -0,0 +1,70 @@ +# Licensed under the Apache License, Version 2.0 (the "License"); you may +# not use this file except in compliance with the License. You may obtain +# a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT +# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the +# License for the specific language governing permissions and limitations +# under the License. + +import mock + +from nova.api.openstack.compute import migrations +from nova.policies import migrations as migrations_policies +from nova.tests.unit.api.openstack import fakes +from nova.tests.unit.policies import base + + +class MigrationsPolicyTest(base.BasePolicyTest): + """Test Migrations APIs policies with all possible context. + + This class defines the set of context with different roles + which are allowed and not allowed to pass the policy checks. + With those set of context, it will call the API operation and + verify the expected behaviour. + """ + + def setUp(self): + super(MigrationsPolicyTest, self).setUp() + self.controller = migrations.MigrationsController() + self.req = fakes.HTTPRequest.blank('') + + # Check that admin is able to list migrations. + self.admin_authorized_contexts = [ + self.legacy_admin_context, self.system_admin_context, + self.project_admin_context + ] + # Check that non-admin is not able to list migrations. + self.admin_unauthorized_contexts = [ + self.system_member_context, self.system_reader_context, + self.system_foo_context, self.project_member_context, + self.project_reader_context, self.project_foo_context, + self.other_project_member_context + ] + + @mock.patch('nova.compute.api.API.get_migrations') + def test_list_migrations_policy(self, mock_migration): + rule_name = migrations_policies.POLICY_ROOT % 'index' + self.common_policy_check(self.admin_authorized_contexts, + self.admin_unauthorized_contexts, + rule_name, self.controller.index, + self.req) + + +class MigrationsScopeTypePolicyTest(MigrationsPolicyTest): + """Test Migrations APIs policies with system scope enabled. + + This class set the nova.conf [oslo_policy] enforce_scope to True + so that we can switch on the scope checking on oslo policy side. + It defines the set of context with scoped token + which are allowed and not allowed to pass the policy checks. + With those set of context, it will run the API operation and + verify the expected behaviour. + """ + + def setUp(self): + super(MigrationsScopeTypePolicyTest, self).setUp() + self.flags(enforce_scope=True, group="oslo_policy")