From e03f8a115de2c6710938d1c46ceff12bca59252a Mon Sep 17 00:00:00 2001 From: Ghanshyam Mann Date: Tue, 31 Mar 2020 02:35:11 -0500 Subject: [PATCH] Add test coverage of existing pause server policies Current tests do not have good test coverage of existing policies. Either tests for policies do not exist or if they exist then they do not cover the actual negative and positive testing. For Example, if any policy with default rule as admin only then test should verify: - policy check pass with context having admin or server owner - policy check fail with context having non-admin and not server owner As discussed in policy-defaults-refresh, to change the policies with new default roles and scope_type, we need to have the enough testing coverage of existing policy behavior. When we will add the scope_type in policies or new default roles, then these test coverage will be extended to adopt the new changes and also make sure we do not break the existing behavior. This commit covers the testing coverage of existing pause server policies. Partial implement blueprint policy-defaults-refresh Change-Id: I9eb4d7f348481425992713bd5a0351d710d43669 --- .../openstack/compute/test_pause_server.py | 78 ------------ nova/tests/unit/policies/test_pause_server.py | 119 ++++++++++++++++++ 2 files changed, 119 insertions(+), 78 deletions(-) create mode 100644 nova/tests/unit/policies/test_pause_server.py diff --git a/nova/tests/unit/api/openstack/compute/test_pause_server.py b/nova/tests/unit/api/openstack/compute/test_pause_server.py index ec58587fa2d0..0d64c873378b 100644 --- a/nova/tests/unit/api/openstack/compute/test_pause_server.py +++ b/nova/tests/unit/api/openstack/compute/test_pause_server.py @@ -13,15 +13,9 @@ # License for the specific language governing permissions and limitations # under the License. -import mock - from nova.api.openstack.compute import pause_server as \ pause_server_v21 -from nova import exception -from nova import test from nova.tests.unit.api.openstack.compute import admin_only_action_common -from nova.tests.unit.api.openstack import fakes -from nova.tests.unit import fake_instance class PauseServerTestsV21(admin_only_action_common.CommonTests): @@ -57,75 +51,3 @@ class PauseServerTestsV21(admin_only_action_common.CommonTests): def test_actions_with_locked_instance(self): self._test_actions_with_locked_instance(['_pause', '_unpause']) - - -class PauseServerPolicyEnforcementV21(test.NoDBTestCase): - - def setUp(self): - super(PauseServerPolicyEnforcementV21, self).setUp() - self.controller = pause_server_v21.PauseServerController() - self.req = fakes.HTTPRequest.blank('') - - @mock.patch('nova.api.openstack.common.get_instance') - def test_pause_policy_failed_with_other_project(self, get_instance_mock): - get_instance_mock.return_value = fake_instance.fake_instance_obj( - self.req.environ['nova.context'], - project_id=self.req.environ['nova.context'].project_id) - rule_name = "os_compute_api:os-pause-server:pause" - self.policy.set_rules({rule_name: "project_id:%(project_id)s"}) - # Change the project_id in request context. - self.req.environ['nova.context'].project_id = 'other-project' - exc = self.assertRaises( - exception.PolicyNotAuthorized, - self.controller._pause, self.req, fakes.FAKE_UUID, - body={'pause': {}}) - self.assertEqual( - "Policy doesn't allow %s to be performed." % rule_name, - exc.format_message()) - - @mock.patch('nova.api.openstack.common.get_instance') - def test_pause_overridden_policy_failed_with_other_user_in_same_project( - self, get_instance_mock): - get_instance_mock.return_value = ( - fake_instance.fake_instance_obj(self.req.environ['nova.context'])) - rule_name = "os_compute_api:os-pause-server:pause" - self.policy.set_rules({rule_name: "user_id:%(user_id)s"}) - # Change the user_id in request context. - self.req.environ['nova.context'].user_id = 'other-user' - exc = self.assertRaises(exception.PolicyNotAuthorized, - self.controller._pause, self.req, - fakes.FAKE_UUID, body={'pause': {}}) - self.assertEqual( - "Policy doesn't allow %s to be performed." % rule_name, - exc.format_message()) - - @mock.patch('nova.compute.api.API.pause') - @mock.patch('nova.api.openstack.common.get_instance') - def test_pause_overridden_policy_pass_with_same_user(self, - get_instance_mock, - pause_mock): - instance = fake_instance.fake_instance_obj( - self.req.environ['nova.context'], - user_id=self.req.environ['nova.context'].user_id) - get_instance_mock.return_value = instance - rule_name = "os_compute_api:os-pause-server:pause" - self.policy.set_rules({rule_name: "user_id:%(user_id)s"}) - self.controller._pause(self.req, fakes.FAKE_UUID, body={'pause': {}}) - pause_mock.assert_called_once_with(self.req.environ['nova.context'], - instance) - - @mock.patch('nova.api.openstack.common.get_instance') - def test_unpause_policy_failed(self, get_instance_mock): - instance = fake_instance.fake_instance_obj( - self.req.environ['nova.context'], - user_id=self.req.environ['nova.context'].user_id) - get_instance_mock.return_value = instance - rule_name = "os_compute_api:os-pause-server:unpause" - self.policy.set_rules({rule_name: "project:non_fake"}) - exc = self.assertRaises( - exception.PolicyNotAuthorized, - self.controller._unpause, self.req, fakes.FAKE_UUID, - body={'unpause': {}}) - self.assertEqual( - "Policy doesn't allow %s to be performed." % rule_name, - exc.format_message()) diff --git a/nova/tests/unit/policies/test_pause_server.py b/nova/tests/unit/policies/test_pause_server.py new file mode 100644 index 000000000000..5f2f4cd132af --- /dev/null +++ b/nova/tests/unit/policies/test_pause_server.py @@ -0,0 +1,119 @@ +# Licensed under the Apache License, Version 2.0 (the "License"); you may +# not use this file except in compliance with the License. You may obtain +# a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT +# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the +# License for the specific language governing permissions and limitations +# under the License. + +import fixtures +import mock +from nova.policies import pause_server as ps_policies +from oslo_utils.fixture import uuidsentinel as uuids +from oslo_utils import timeutils + +from nova.api.openstack.compute import pause_server +from nova.compute import vm_states +from nova import exception +from nova.tests.unit.api.openstack import fakes +from nova.tests.unit import fake_instance +from nova.tests.unit.policies import base + + +class PauseServerPolicyTest(base.BasePolicyTest): + """Test Pause server APIs policies with all possible context. + This class defines the set of context with different roles + which are allowed and not allowed to pass the policy checks. + With those set of context, it will call the API operation and + verify the expected behaviour. + """ + + def setUp(self): + super(PauseServerPolicyTest, self).setUp() + self.controller = pause_server.PauseServerController() + self.req = fakes.HTTPRequest.blank('') + user_id = self.req.environ['nova.context'].user_id + self.mock_get = self.useFixture( + fixtures.MockPatch('nova.api.openstack.common.get_instance')).mock + uuid = uuids.fake_id + self.instance = fake_instance.fake_instance_obj( + self.project_member_context, + id=1, uuid=uuid, project_id=self.project_id, + user_id=user_id, vm_state=vm_states.ACTIVE, + task_state=None, launched_at=timeutils.utcnow()) + self.mock_get.return_value = self.instance + + # Check that admin or and server owner is able to pause/unpause + # the sevrer + self.admin_or_owner_authorized_contexts = [ + self.legacy_admin_context, self.system_admin_context, + self.project_admin_context, self.project_member_context, + self.project_reader_context, self.project_foo_context] + # Check that non-admin/owner is not able to pause/unpause + # the server + self.admin_or_owner_unauthorized_contexts = [ + self.system_member_context, self.system_reader_context, + self.system_foo_context, + self.other_project_member_context + ] + + @mock.patch('nova.compute.api.API.pause') + def test_pause_server_policy(self, mock_pause): + rule_name = ps_policies.POLICY_ROOT % 'pause' + self.common_policy_check(self.admin_or_owner_authorized_contexts, + self.admin_or_owner_unauthorized_contexts, + rule_name, + self.controller._pause, + self.req, self.instance.uuid, + body={'pause': {}}) + + @mock.patch('nova.compute.api.API.unpause') + def test_unpause_server_policy(self, mock_unpause): + rule_name = ps_policies.POLICY_ROOT % 'unpause' + self.common_policy_check(self.admin_or_owner_authorized_contexts, + self.admin_or_owner_unauthorized_contexts, + rule_name, + self.controller._unpause, + self.req, self.instance.uuid, + body={'unpause': {}}) + + def test_pause_server_policy_failed_with_other_user(self): + # Change the user_id in request context. + req = fakes.HTTPRequest.blank('') + req.environ['nova.context'].user_id = 'other-user' + rule_name = ps_policies.POLICY_ROOT % 'pause' + self.policy.set_rules({rule_name: "user_id:%(user_id)s"}) + exc = self.assertRaises( + exception.PolicyNotAuthorized, self.controller._pause, + req, fakes.FAKE_UUID, body={'pause': {}}) + self.assertEqual( + "Policy doesn't allow %s to be performed." % rule_name, + exc.format_message()) + + @mock.patch('nova.compute.api.API.pause') + def test_pause_sevrer_overridden_policy_pass_with_same_user( + self, mock_pause): + rule_name = ps_policies.POLICY_ROOT % 'pause' + self.policy.set_rules({rule_name: "user_id:%(user_id)s"}) + self.controller._pause(self.req, + fakes.FAKE_UUID, + body={'pause': {}}) + + +class PauseServerScopeTypePolicyTest(PauseServerPolicyTest): + """Test Pause Server APIs policies with system scope enabled. + This class set the nova.conf [oslo_policy] enforce_scope to True + so that we can switch on the scope checking on oslo policy side. + It defines the set of context with scoped token + which are allowed and not allowed to pass the policy checks. + With those set of context, it will run the API operation and + verify the expected behaviour. + """ + + def setUp(self): + super(PauseServerScopeTypePolicyTest, self).setUp() + self.flags(enforce_scope=True, group="oslo_policy")