From 66988da3db3bf73cd380db303bd0ca9bebcb3c64 Mon Sep 17 00:00:00 2001 From: Jay Pipes Date: Thu, 20 Jul 2017 11:58:09 -0400 Subject: [PATCH] Remove improper LOG.exception() calls in placement The PUT /allocations Placement API handler was improperly calling LOG.exception() when two normal-operation events were occurring: 1) When a concurrent attempt to allocate against the same resource providers had occurred 2) When, due to another process consuming resources concurrently resulted in capacity being exceeded on one or more of the requested providers Neither of the above scenarios is a software error and so the LOG.exception() calls have been removed. Change-Id: I569b28313e52d979ac9be5bea88c021a0664d851 Fixes-bug: #1705487 --- nova/api/openstack/placement/handlers/allocation.py | 2 -- 1 file changed, 2 deletions(-) diff --git a/nova/api/openstack/placement/handlers/allocation.py b/nova/api/openstack/placement/handlers/allocation.py index acaa456604d8..5f13ccd98307 100644 --- a/nova/api/openstack/placement/handlers/allocation.py +++ b/nova/api/openstack/placement/handlers/allocation.py @@ -257,11 +257,9 @@ def _set_allocations(req, schema): "%(rp_uuid)s: %(error)s") % {'rp_uuid': resource_provider_uuid, 'error': exc}) except exception.InvalidInventory as exc: - LOG.exception("Bad inventory") raise webob.exc.HTTPConflict( _('Unable to allocate inventory: %(error)s') % {'error': exc}) except exception.ConcurrentUpdateDetected as exc: - LOG.exception("Concurrent Update") raise webob.exc.HTTPConflict( _('Inventory changed while attempting to allocate: %(error)s') % {'error': exc})