openstack
/
nova
Code Issues Proposed changes

skip lock_unlock_server test for cells 

The cells architecture of doing db replay makes this call
fundamentally racey for cells. The contract is that if you request an
action on a server and it is locked, you get a 409 at the API, and are
done. If you get a 2xx, the resource is not locked, and life is good.

Except in cells, the API db will be updated, and the API will return
all is well. Except the db replay hasn't happened for the cell, so the
additional check in the nova compute for locked blows up.

The fix probably involves the nova-compute check doing a timed retry
under cells because of replication lags.

Conflicts:
        devstack/tempest-dsvm-cells-rc

NOTE(mriedem): The conflict is due to an additional test being
skipped in liberty that wasn't skipped in mitaka.

Change-Id: Ic18407b8372c286d8e258860f3e2bf76eceef2aa
Related-Bug: #1466696
(cherry picked from commit 02de17c72a)
This commit is contained in:
Sean Dague 2015-11-09 16:54:19 -05:00 committed by Matt Riedemann
parent b9a1440fb6
commit d836c7172d
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
devstack/tempest-dsvm-cells-rc
View File

@ -79,6 +79,8 @@ r="$r|(?:tempest\.api\.compute.servers\.test_disk_config\.ServerDiskConfigTestJS
r="$r|(?:tempest\.api\.compute\.servers\.test_server_actions\.ServerActionsTestJSON\\.test_rebuild_server_in_stop_state*)"
# scheduler hints apparently don't work in devstack cells
r="$r|(?:tempest\.scenario\.test_server_multinode\.TestServerMultinode\.test_schedule_to_all_nodes)"
# https://bugs.launchpad.net/nova/+bug/1466696 - Cells: Race between instance 'unlock' and 'stop' can cause 'stop' to fail
r="$r|(?:tempest\.api\.compute\.servers\.test_server_actions\.ServerActionsTestJSON\.test_lock_unlock_server)"
r="$r).*$"
export DEVSTACK_GATE_TEMPEST_REGEX="$r"