From dc32774ecc9335860677bc2562451093d8e952a1 Mon Sep 17 00:00:00 2001 From: Matthew Edmonds Date: Mon, 22 Jan 2018 09:46:53 -0500 Subject: [PATCH] remove unnecessary conf imports There are a bunch of files that define CONF but don't ever reference it. This cleans that up, removing unnecessary imports. In order to get flake8 to pass I also had to remove some (unrelated) unused imports from touched files. Change-Id: Ib96ebeeb5e4bfedb20afb02c56da1521df9fac4f --- nova/api/openstack/compute/instance_usage_audit_log.py | 3 --- nova/api/openstack/compute/routes.py | 4 ---- nova/console/api.py | 3 --- nova/console/securityproxy/rfb.py | 3 --- nova/objects/console_auth_token.py | 3 +-- nova/pci/whitelist.py | 3 --- nova/scheduler/filters/disk_filter.py | 3 --- .../functional/api_sample_tests/test_admin_password.py | 3 --- nova/tests/functional/api_sample_tests/test_cells.py | 3 --- nova/tests/functional/api_sample_tests/test_images.py | 3 --- .../functional/api_sample_tests/test_server_metadata.py | 3 --- nova/tests/functional/api_sample_tests/test_servers_ips.py | 3 --- nova/tests/functional/regressions/test_bug_1558866.py | 3 --- nova/tests/functional/test_compute_mgr.py | 4 ---- .../unit/api/openstack/compute/test_availability_zone.py | 2 -- .../unit/api/openstack/compute/test_block_device_mapping.py | 3 --- .../api/openstack/compute/test_block_device_mapping_v1.py | 3 --- nova/tests/unit/api/openstack/compute/test_config_drive.py | 3 --- .../unit/api/openstack/compute/test_scheduler_hints.py | 4 ---- nova/tests/unit/api/openstack/compute/test_user_data.py | 2 -- nova/tests/unit/cells/test_cells_messaging.py | 3 --- nova/tests/unit/cells/test_cells_rpcapi.py | 3 --- nova/tests/unit/cells/test_cells_scheduler.py | 3 --- nova/tests/unit/compute/test_compute_cells.py | 2 -- nova/tests/unit/compute/test_compute_utils.py | 4 ---- nova/tests/unit/compute/test_compute_xen.py | 3 --- nova/tests/unit/compute/test_rpcapi.py | 3 --- nova/tests/unit/conf_fixture.py | 4 ---- nova/tests/unit/console/test_console.py | 3 --- nova/tests/unit/scheduler/test_rpcapi.py | 3 --- nova/tests/unit/scheduler/test_scheduler.py | 3 --- nova/tests/unit/test_baserpc.py | 3 --- nova/tests/unit/test_policy.py | 3 --- nova/tests/unit/test_service_auth.py | 4 ---- nova/tests/unit/virt/powervm/test_vif.py | 3 --- nova/virt/libvirt/volume/volume.py | 6 +----- nova/virt/powervm/disk/ssp.py | 2 -- nova/virt/powervm/vif.py | 3 --- 38 files changed, 2 insertions(+), 117 deletions(-) diff --git a/nova/api/openstack/compute/instance_usage_audit_log.py b/nova/api/openstack/compute/instance_usage_audit_log.py index 0becf2cb0b4e..702aceab7d32 100644 --- a/nova/api/openstack/compute/instance_usage_audit_log.py +++ b/nova/api/openstack/compute/instance_usage_audit_log.py @@ -21,13 +21,10 @@ import webob.exc from nova.api.openstack import wsgi from nova import compute from nova.compute import rpcapi as compute_rpcapi -import nova.conf from nova.i18n import _ from nova.policies import instance_usage_audit_log as iual_policies from nova import utils -CONF = nova.conf.CONF - class InstanceUsageAuditLogController(wsgi.Controller): def __init__(self): diff --git a/nova/api/openstack/compute/routes.py b/nova/api/openstack/compute/routes.py index e6d55c27347c..06ba417cd2df 100644 --- a/nova/api/openstack/compute/routes.py +++ b/nova/api/openstack/compute/routes.py @@ -94,10 +94,6 @@ from nova.api.openstack.compute import virtual_interfaces from nova.api.openstack.compute import volumes from nova.api.openstack import wsgi from nova.api import wsgi as base_wsgi -import nova.conf - - -CONF = nova.conf.CONF def _create_controller(main_controller, controller_list, diff --git a/nova/console/api.py b/nova/console/api.py index 93821c818521..e5204d9bb4f9 100644 --- a/nova/console/api.py +++ b/nova/console/api.py @@ -17,13 +17,10 @@ from nova.compute import rpcapi as compute_rpcapi -import nova.conf from nova.console import rpcapi as console_rpcapi from nova.db import base from nova import objects -CONF = nova.conf.CONF - class API(base.Base): """API for spinning up or down console proxy connections.""" diff --git a/nova/console/securityproxy/rfb.py b/nova/console/securityproxy/rfb.py index c660f0f8fcea..09f36fa9473d 100644 --- a/nova/console/securityproxy/rfb.py +++ b/nova/console/securityproxy/rfb.py @@ -15,7 +15,6 @@ import struct -from oslo_config import cfg from oslo_log import log as logging import six @@ -27,8 +26,6 @@ from nova.i18n import _ LOG = logging.getLogger(__name__) -CONF = cfg.CONF - class RFBSecurityProxy(base.SecurityProxy): """RFB Security Proxy Negotiation Helper. diff --git a/nova/objects/console_auth_token.py b/nova/objects/console_auth_token.py index 606cd09b3c6b..8eef55dcf2b3 100644 --- a/nova/objects/console_auth_token.py +++ b/nova/objects/console_auth_token.py @@ -19,7 +19,6 @@ from oslo_utils import strutils from oslo_utils import timeutils from oslo_utils import uuidutils -import nova.conf from nova import db from nova import exception from nova.i18n import _ @@ -27,7 +26,7 @@ from nova.objects import base from nova.objects import fields from nova import utils -CONF = nova.conf.CONF + LOG = logging.getLogger(__name__) diff --git a/nova/pci/whitelist.py b/nova/pci/whitelist.py index 7266a57af8f0..3c9984094d00 100644 --- a/nova/pci/whitelist.py +++ b/nova/pci/whitelist.py @@ -16,13 +16,10 @@ from oslo_serialization import jsonutils -import nova.conf from nova import exception from nova.i18n import _ from nova.pci import devspec -CONF = nova.conf.CONF - class Whitelist(object): """White list class to represent assignable pci devices. diff --git a/nova/scheduler/filters/disk_filter.py b/nova/scheduler/filters/disk_filter.py index 1c478d69dfa8..1a29d409fe91 100644 --- a/nova/scheduler/filters/disk_filter.py +++ b/nova/scheduler/filters/disk_filter.py @@ -15,15 +15,12 @@ from oslo_log import log as logging -import nova.conf from nova.i18n import _LW from nova.scheduler import filters from nova.scheduler.filters import utils LOG = logging.getLogger(__name__) -CONF = nova.conf.CONF - class DiskFilter(filters.BaseHostFilter): """Disk Filter with over subscription flag.""" diff --git a/nova/tests/functional/api_sample_tests/test_admin_password.py b/nova/tests/functional/api_sample_tests/test_admin_password.py index 038c100563fa..147a1cd5a450 100644 --- a/nova/tests/functional/api_sample_tests/test_admin_password.py +++ b/nova/tests/functional/api_sample_tests/test_admin_password.py @@ -13,11 +13,8 @@ # License for the specific language governing permissions and limitations # under the License. -import nova.conf from nova.tests.functional.api_sample_tests import test_servers -CONF = nova.conf.CONF - class AdminPasswordJsonTest(test_servers.ServersSampleBase): sample_dir = 'os-admin-password' diff --git a/nova/tests/functional/api_sample_tests/test_cells.py b/nova/tests/functional/api_sample_tests/test_cells.py index 82668b0ca4b7..feb3fd58e8d9 100644 --- a/nova/tests/functional/api_sample_tests/test_cells.py +++ b/nova/tests/functional/api_sample_tests/test_cells.py @@ -17,13 +17,10 @@ import mock from six.moves import range from nova.cells import state -import nova.conf from nova.db.sqlalchemy import models from nova import exception from nova.tests.functional.api_sample_tests import api_sample_base -CONF = nova.conf.CONF - class CellsSampleJsonTest(api_sample_base.ApiSampleTestBaseV21): sample_dir = "os-cells" diff --git a/nova/tests/functional/api_sample_tests/test_images.py b/nova/tests/functional/api_sample_tests/test_images.py index a30db51dd8fd..b0868ce4d0fd 100644 --- a/nova/tests/functional/api_sample_tests/test_images.py +++ b/nova/tests/functional/api_sample_tests/test_images.py @@ -13,12 +13,9 @@ # License for the specific language governing permissions and limitations # under the License. -import nova.conf from nova.tests.functional.api_sample_tests import api_sample_base from nova.tests.unit.image import fake -CONF = nova.conf.CONF - class ImagesSampleJsonTest(api_sample_base.ApiSampleTestBaseV21): sample_dir = 'images' diff --git a/nova/tests/functional/api_sample_tests/test_server_metadata.py b/nova/tests/functional/api_sample_tests/test_server_metadata.py index 4e0e63706a48..622f22eaf24d 100644 --- a/nova/tests/functional/api_sample_tests/test_server_metadata.py +++ b/nova/tests/functional/api_sample_tests/test_server_metadata.py @@ -13,11 +13,8 @@ # License for the specific language governing permissions and limitations # under the License. -import nova.conf from nova.tests.functional.api_sample_tests import test_servers -CONF = nova.conf.CONF - class ServersMetadataJsonTest(test_servers.ServersSampleBase): sample_dir = 'server-metadata' diff --git a/nova/tests/functional/api_sample_tests/test_servers_ips.py b/nova/tests/functional/api_sample_tests/test_servers_ips.py index c68ece76680a..6182dc6c9788 100644 --- a/nova/tests/functional/api_sample_tests/test_servers_ips.py +++ b/nova/tests/functional/api_sample_tests/test_servers_ips.py @@ -13,11 +13,8 @@ # License for the specific language governing permissions and limitations # under the License. -import nova.conf from nova.tests.functional.api_sample_tests import test_servers -CONF = nova.conf.CONF - class ServersIpsJsonTest(test_servers.ServersSampleBase): sample_dir = 'server-ips' diff --git a/nova/tests/functional/regressions/test_bug_1558866.py b/nova/tests/functional/regressions/test_bug_1558866.py index d1ad58cd1ad8..b40d55b528dd 100644 --- a/nova/tests/functional/regressions/test_bug_1558866.py +++ b/nova/tests/functional/regressions/test_bug_1558866.py @@ -14,15 +14,12 @@ import datetime -import nova.conf from nova import test from nova.tests import fixtures as nova_fixtures from nova.tests.functional.api import client as api_client from nova.tests.unit.image import fake as fake_image from nova.tests.unit import policy_fixture -CONF = nova.conf.CONF - class TestServerGet(test.TestCase): diff --git a/nova/tests/functional/test_compute_mgr.py b/nova/tests/functional/test_compute_mgr.py index cea18dec8a52..84ec634a15e9 100644 --- a/nova/tests/functional/test_compute_mgr.py +++ b/nova/tests/functional/test_compute_mgr.py @@ -11,7 +11,6 @@ # under the License. import mock -from oslo_config import cfg from nova import context from nova import objects @@ -22,9 +21,6 @@ from nova.tests.unit import fake_network from nova.tests.unit import fake_server_actions -CONF = cfg.CONF - - class ComputeManagerTestCase(test.TestCase): def setUp(self): super(ComputeManagerTestCase, self).setUp() diff --git a/nova/tests/unit/api/openstack/compute/test_availability_zone.py b/nova/tests/unit/api/openstack/compute/test_availability_zone.py index 9859e1d9deee..d3142b7ea268 100644 --- a/nova/tests/unit/api/openstack/compute/test_availability_zone.py +++ b/nova/tests/unit/api/openstack/compute/test_availability_zone.py @@ -16,7 +16,6 @@ import datetime import iso8601 import mock -from oslo_config import cfg from nova.api.openstack.compute import availability_zone as az_v21 from nova.api.openstack.compute import servers as servers_v21 @@ -34,7 +33,6 @@ from nova.tests.unit.objects import test_service from nova.tests import uuidsentinel -CONF = cfg.CONF FAKE_UUID = fakes.FAKE_UUID diff --git a/nova/tests/unit/api/openstack/compute/test_block_device_mapping.py b/nova/tests/unit/api/openstack/compute/test_block_device_mapping.py index d21ef662d9a4..2d1826a16b59 100644 --- a/nova/tests/unit/api/openstack/compute/test_block_device_mapping.py +++ b/nova/tests/unit/api/openstack/compute/test_block_device_mapping.py @@ -14,7 +14,6 @@ # under the License. import mock -from oslo_config import cfg from oslo_serialization import jsonutils from six.moves import range from webob import exc @@ -29,8 +28,6 @@ from nova.tests.unit.api.openstack import fakes from nova.tests.unit.image import fake from nova.tests.unit import matchers -CONF = cfg.CONF - class BlockDeviceMappingTestV21(test.TestCase): validation_error = exception.ValidationError diff --git a/nova/tests/unit/api/openstack/compute/test_block_device_mapping_v1.py b/nova/tests/unit/api/openstack/compute/test_block_device_mapping_v1.py index 95c6a6a33d5b..4b534e115602 100644 --- a/nova/tests/unit/api/openstack/compute/test_block_device_mapping_v1.py +++ b/nova/tests/unit/api/openstack/compute/test_block_device_mapping_v1.py @@ -14,7 +14,6 @@ # under the License. import mock -from oslo_config import cfg from oslo_serialization import jsonutils from webob import exc @@ -28,8 +27,6 @@ from nova.tests.unit.api.openstack import fakes from nova.tests.unit.image import fake from nova.tests import uuidsentinel as uuids -CONF = cfg.CONF - class BlockDeviceMappingTestV21(test.TestCase): validation_error = exception.ValidationError diff --git a/nova/tests/unit/api/openstack/compute/test_config_drive.py b/nova/tests/unit/api/openstack/compute/test_config_drive.py index 2180b0811d40..c87a0b5ac470 100644 --- a/nova/tests/unit/api/openstack/compute/test_config_drive.py +++ b/nova/tests/unit/api/openstack/compute/test_config_drive.py @@ -14,7 +14,6 @@ # under the License. import mock -from oslo_config import cfg from oslo_serialization import jsonutils from nova.api.openstack.compute import servers as servers_v21 @@ -26,8 +25,6 @@ from nova.tests.unit.api.openstack import fakes from nova.tests.unit.image import fake from nova.tests import uuidsentinel as uuids -CONF = cfg.CONF - class ConfigDriveTestV21(test.TestCase): base_url = '/v2/fake/servers/' diff --git a/nova/tests/unit/api/openstack/compute/test_scheduler_hints.py b/nova/tests/unit/api/openstack/compute/test_scheduler_hints.py index 28cd72bcf320..c22cfd479d05 100644 --- a/nova/tests/unit/api/openstack/compute/test_scheduler_hints.py +++ b/nova/tests/unit/api/openstack/compute/test_scheduler_hints.py @@ -13,7 +13,6 @@ # License for the specific language governing permissions and limitations # under the License. -from oslo_config import cfg from oslo_serialization import jsonutils from nova.api.openstack import compute @@ -24,9 +23,6 @@ from nova.tests.unit.api.openstack import fakes UUID = fakes.FAKE_UUID -CONF = cfg.CONF - - class SchedulerHintsTestCaseV21(test.TestCase): def setUp(self): diff --git a/nova/tests/unit/api/openstack/compute/test_user_data.py b/nova/tests/unit/api/openstack/compute/test_user_data.py index b7c72ab68bbf..7c5e7198daff 100644 --- a/nova/tests/unit/api/openstack/compute/test_user_data.py +++ b/nova/tests/unit/api/openstack/compute/test_user_data.py @@ -18,7 +18,6 @@ import datetime import uuid import mock -from oslo_config import cfg from oslo_serialization import base64 from oslo_serialization import jsonutils @@ -33,7 +32,6 @@ from nova.tests.unit import fake_instance from nova.tests.unit.image import fake -CONF = cfg.CONF FAKE_UUID = fakes.FAKE_UUID diff --git a/nova/tests/unit/cells/test_cells_messaging.py b/nova/tests/unit/cells/test_cells_messaging.py index 0c5e3c934eab..fa5384066acf 100644 --- a/nova/tests/unit/cells/test_cells_messaging.py +++ b/nova/tests/unit/cells/test_cells_messaging.py @@ -29,7 +29,6 @@ from nova.cells import utils as cells_utils from nova.compute import instance_actions from nova.compute import task_states from nova.compute import vm_states -import nova.conf from nova import context from nova import db from nova import exception @@ -43,8 +42,6 @@ from nova.tests.unit import fake_instance from nova.tests.unit import fake_server_actions from nova.tests import uuidsentinel as uuids -CONF = nova.conf.CONF - class CellsMessageClassesTestCase(test.NoDBTestCase): """Test case for the main Cells Message classes.""" diff --git a/nova/tests/unit/cells/test_cells_rpcapi.py b/nova/tests/unit/cells/test_cells_rpcapi.py index f97a7672ecd6..18d262f5acdd 100644 --- a/nova/tests/unit/cells/test_cells_rpcapi.py +++ b/nova/tests/unit/cells/test_cells_rpcapi.py @@ -20,15 +20,12 @@ import mock import six from nova.cells import rpcapi as cells_rpcapi -import nova.conf from nova import exception from nova import objects from nova import test from nova.tests.unit import fake_instance from nova.tests import uuidsentinel as uuids -CONF = nova.conf.CONF - class CellsAPITestCase(test.NoDBTestCase): """Test case for cells.api interfaces.""" diff --git a/nova/tests/unit/cells/test_cells_scheduler.py b/nova/tests/unit/cells/test_cells_scheduler.py index 320bd83e57b5..6eb9e2519105 100644 --- a/nova/tests/unit/cells/test_cells_scheduler.py +++ b/nova/tests/unit/cells/test_cells_scheduler.py @@ -24,7 +24,6 @@ from nova import block_device from nova.cells import filters from nova.cells import weights from nova.compute import vm_states -import nova.conf from nova import context from nova import db from nova import exception @@ -35,8 +34,6 @@ from nova.tests.unit import fake_block_device from nova.tests import uuidsentinel from nova import utils -CONF = nova.conf.CONF - class FakeFilterClass1(filters.BaseCellFilter): pass diff --git a/nova/tests/unit/compute/test_compute_cells.py b/nova/tests/unit/compute/test_compute_cells.py index dcdd4cce6c2e..4e8edaf72605 100644 --- a/nova/tests/unit/compute/test_compute_cells.py +++ b/nova/tests/unit/compute/test_compute_cells.py @@ -30,7 +30,6 @@ from nova.compute import flavors from nova.compute import power_state from nova.compute import utils as compute_utils from nova.compute import vm_states -import nova.conf from nova import context from nova import db from nova.db.sqlalchemy import api as db_api @@ -48,7 +47,6 @@ from nova.tests import uuidsentinel as uuids ORIG_COMPUTE_API = None -CONF = nova.conf.CONF FAKE_IMAGE_REF = uuids.image_ref NODENAME = 'fakenode1' diff --git a/nova/tests/unit/compute/test_compute_utils.py b/nova/tests/unit/compute/test_compute_utils.py index 2738e798f056..914ed1c50f18 100644 --- a/nova/tests/unit/compute/test_compute_utils.py +++ b/nova/tests/unit/compute/test_compute_utils.py @@ -28,7 +28,6 @@ from nova.compute import manager from nova.compute import power_state from nova.compute import task_states from nova.compute import utils as compute_utils -import nova.conf from nova import context from nova import exception from nova.image import glance @@ -45,13 +44,10 @@ from nova.tests.unit import fake_instance from nova.tests.unit import fake_network from nova.tests.unit import fake_notifier from nova.tests.unit import fake_server_actions -import nova.tests.unit.image.fake from nova.tests.unit.objects import test_flavor from nova.tests import uuidsentinel as uuids -CONF = nova.conf.CONF - FAKE_IMAGE_REF = uuids.image_ref diff --git a/nova/tests/unit/compute/test_compute_xen.py b/nova/tests/unit/compute/test_compute_xen.py index aa5121876979..a99e3e3b0bb6 100644 --- a/nova/tests/unit/compute/test_compute_xen.py +++ b/nova/tests/unit/compute/test_compute_xen.py @@ -16,7 +16,6 @@ import mock from nova.compute import manager from nova.compute import power_state -import nova.conf from nova import context from nova import objects from nova.objects import instance as instance_obj @@ -25,8 +24,6 @@ from nova.tests.unit import fake_instance from nova.tests.unit.virt.xenapi import stubs from nova.virt.xenapi import vm_utils -CONF = nova.conf.CONF - class ComputeXenTestCase(stubs.XenAPITestBaseNoDB): def setUp(self): diff --git a/nova/tests/unit/compute/test_rpcapi.py b/nova/tests/unit/compute/test_rpcapi.py index 973908078a84..415b16ec1afb 100644 --- a/nova/tests/unit/compute/test_rpcapi.py +++ b/nova/tests/unit/compute/test_rpcapi.py @@ -20,7 +20,6 @@ import mock from oslo_serialization import jsonutils from nova.compute import rpcapi as compute_rpcapi -import nova.conf from nova import context from nova import exception from nova.objects import block_device as objects_block_dev @@ -32,8 +31,6 @@ from nova.tests.unit import fake_flavor from nova.tests.unit import fake_instance from nova.tests import uuidsentinel as uuids -CONF = nova.conf.CONF - class ComputeRpcAPITestCase(test.NoDBTestCase): diff --git a/nova/tests/unit/conf_fixture.py b/nova/tests/unit/conf_fixture.py index 4fa40a79c1da..4dd0a5e09604 100644 --- a/nova/tests/unit/conf_fixture.py +++ b/nova/tests/unit/conf_fixture.py @@ -17,15 +17,11 @@ from oslo_config import fixture as config_fixture from oslo_policy import opts as policy_opts -import nova.conf from nova.conf import paths from nova import config from nova import ipv6 -import nova.keymgr from nova.tests.unit import utils -CONF = nova.conf.CONF - class ConfFixture(config_fixture.Config): """Fixture to manage global conf settings.""" diff --git a/nova/tests/unit/console/test_console.py b/nova/tests/unit/console/test_console.py index e4bf1d5433c5..18aa46cfefa1 100644 --- a/nova/tests/unit/console/test_console.py +++ b/nova/tests/unit/console/test_console.py @@ -20,7 +20,6 @@ import fixtures import mock from nova.compute import rpcapi as compute_rpcapi -import nova.conf from nova.console import api as console_api from nova.console import manager as console_manager from nova import context @@ -31,8 +30,6 @@ from nova import test from nova.tests.unit import fake_instance from nova.tests.unit import fake_xvp_console_proxy -CONF = nova.conf.CONF - class ConsoleTestCase(test.TestCase): """Test case for console proxy manager.""" diff --git a/nova/tests/unit/scheduler/test_rpcapi.py b/nova/tests/unit/scheduler/test_rpcapi.py index bc44d7532b01..e655afa0d07a 100644 --- a/nova/tests/unit/scheduler/test_rpcapi.py +++ b/nova/tests/unit/scheduler/test_rpcapi.py @@ -17,7 +17,6 @@ Unit Tests for nova.scheduler.rpcapi """ import mock -from oslo_config import cfg from nova import context from nova import exception as exc @@ -26,8 +25,6 @@ from nova.scheduler import rpcapi as scheduler_rpcapi from nova import test from nova.tests import uuidsentinel as uuids -CONF = cfg.CONF - class SchedulerRpcAPITestCase(test.NoDBTestCase): def _test_scheduler_api(self, method, rpc_method, expected_args=None, diff --git a/nova/tests/unit/scheduler/test_scheduler.py b/nova/tests/unit/scheduler/test_scheduler.py index 204fcbc43d47..50454a4649c0 100644 --- a/nova/tests/unit/scheduler/test_scheduler.py +++ b/nova/tests/unit/scheduler/test_scheduler.py @@ -20,7 +20,6 @@ Tests For Scheduler import mock import oslo_messaging as messaging -import nova.conf from nova import context from nova import objects from nova.scheduler import caching_scheduler @@ -35,8 +34,6 @@ from nova.tests.unit import fake_server_actions from nova.tests.unit.scheduler import fakes from nova.tests import uuidsentinel as uuids -CONF = nova.conf.CONF - class SchedulerManagerInitTestCase(test.NoDBTestCase): """Test case for scheduler manager initiation.""" diff --git a/nova/tests/unit/test_baserpc.py b/nova/tests/unit/test_baserpc.py index b0a8c64a9171..7f2ef87f1899 100644 --- a/nova/tests/unit/test_baserpc.py +++ b/nova/tests/unit/test_baserpc.py @@ -20,12 +20,9 @@ Test the base rpc API. from nova import baserpc from nova.compute import rpcapi as compute_rpcapi -import nova.conf from nova import context from nova import test -CONF = nova.conf.CONF - class BaseAPITestCase(test.TestCase): diff --git a/nova/tests/unit/test_policy.py b/nova/tests/unit/test_policy.py index f0f7af35b4cf..a6f4fe1954ad 100644 --- a/nova/tests/unit/test_policy.py +++ b/nova/tests/unit/test_policy.py @@ -22,7 +22,6 @@ from oslo_policy import policy as oslo_policy from oslo_serialization import jsonutils import requests_mock -import nova.conf from nova import context from nova import exception from nova import policy @@ -31,8 +30,6 @@ from nova.tests.unit import fake_policy from nova.tests.unit import policy_fixture from nova import utils -CONF = nova.conf.CONF - class PolicyFileTestCase(test.NoDBTestCase): def setUp(self): diff --git a/nova/tests/unit/test_service_auth.py b/nova/tests/unit/test_service_auth.py index 863143ad0e8c..db2a2e28992e 100644 --- a/nova/tests/unit/test_service_auth.py +++ b/nova/tests/unit/test_service_auth.py @@ -14,15 +14,11 @@ from keystoneauth1 import loading as ks_loading from keystoneauth1 import service_token import mock -import nova.conf from nova import context from nova import service_auth from nova import test -CONF = nova.conf.CONF - - class ServiceAuthTestCase(test.NoDBTestCase): def setUp(self): diff --git a/nova/tests/unit/virt/powervm/test_vif.py b/nova/tests/unit/virt/powervm/test_vif.py index c6a34439381c..985c48abe5b4 100644 --- a/nova/tests/unit/virt/powervm/test_vif.py +++ b/nova/tests/unit/virt/powervm/test_vif.py @@ -15,7 +15,6 @@ # under the License. import mock -from oslo_config import cfg from pypowervm import exceptions as pvm_ex from pypowervm.wrappers import network as pvm_net @@ -24,8 +23,6 @@ from nova.network import model from nova import test from nova.virt.powervm import vif -CONF = cfg.CONF - def cna(mac): """Builds a mock Client Network Adapter for unit tests.""" diff --git a/nova/virt/libvirt/volume/volume.py b/nova/virt/libvirt/volume/volume.py index 48145a9d3be5..d8c552d62e1a 100644 --- a/nova/virt/libvirt/volume/volume.py +++ b/nova/virt/libvirt/volume/volume.py @@ -18,18 +18,14 @@ from oslo_log import log as logging - -import nova.conf from nova import exception from nova import profiler from nova.virt import block_device as driver_block_device from nova.virt.libvirt import config as vconfig -import nova.virt.libvirt.driver from nova.virt.libvirt import utils as libvirt_utils -LOG = logging.getLogger(__name__) -CONF = nova.conf.CONF +LOG = logging.getLogger(__name__) @profiler.trace_cls("volume_api") diff --git a/nova/virt/powervm/disk/ssp.py b/nova/virt/powervm/disk/ssp.py index 00fa59cd4563..047795dd0c34 100644 --- a/nova/virt/powervm/disk/ssp.py +++ b/nova/virt/powervm/disk/ssp.py @@ -25,14 +25,12 @@ import pypowervm.util as pvm_u import pypowervm.wrappers.cluster as pvm_clust import pypowervm.wrappers.storage as pvm_stg -import nova.conf from nova import exception from nova import image from nova.virt.powervm import vm LOG = logging.getLogger(__name__) -CONF = nova.conf.CONF IMAGE_API = image.API() diff --git a/nova/virt/powervm/vif.py b/nova/virt/powervm/vif.py index e493169d65c8..af8adf740ab7 100644 --- a/nova/virt/powervm/vif.py +++ b/nova/virt/powervm/vif.py @@ -16,7 +16,6 @@ import abc -from oslo_config import cfg from oslo_log import log from oslo_serialization import jsonutils from oslo_utils import excutils @@ -45,8 +44,6 @@ VIF_MAPPING = {VIF_TYPE_PVM_SEA: VIF_TYPE_PVM_OVS: 'nova.virt.powervm.vif.PvmOvsVifDriver'} -CONF = cfg.CONF - def _build_vif_driver(adapter, instance, vif): """Returns the appropriate VIF Driver for the given VIF.