openstack
/
nova
Code Issues Proposed changes

Use debug level logging during unit tests 

When unit tests fail we need to debug, so we should have debug level logging on.
We use fixtures FakeLogger during testing, to  enable debug logging pass
in log level as a parameter.
http://bazaar.launchpad.net/~python-fixtures/python-fixtures/trunk/view/head:/lib/fixtures/_fixtures/logger.py#L68

Change-Id: I70790aa39c0774726de71e5fa5751c45e7e34ffd
This commit is contained in:
Joe Gordon 2014-02-06 20:54:31 +00:00
parent 50609d1398
commit f9090b0bd7
2 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
nova/test.py
View File

@ -26,6 +26,7 @@ eventlet.monkey_patch(os=False)
import copy
import gettext
import logging
import os
import shutil
import sys
@ -44,7 +45,7 @@ from nova.network import manager as network_manager
from nova.objects import base as objects_base
from nova.openstack.common.fixture import logging as log_fixture
from nova.openstack.common.fixture import moxstubout
from nova.openstack.common import log as logging
from nova.openstack.common import log as oslo_logging
from nova.openstack.common import timeutils
from nova import paths
from nova import rpc
@ -69,7 +70,7 @@ CONF.import_opt('sqlite_db', 'nova.openstack.common.db.options',
CONF.import_opt('enabled', 'nova.api.openstack', group='osapi_v3')
CONF.set_override('use_stderr', False)
logging.setup('nova')
oslo_logging.setup('nova')
_DB_CACHE = None
_TRUE_VALUES = ('True', 'true', '1', 'yes')
@ -240,7 +241,9 @@ class TestCase(testtools.TestCase):
self.addCleanup(rpc.cleanup)
fs = '%(levelname)s [%(name)s] %(message)s'
self.log_fixture = self.useFixture(fixtures.FakeLogger(format=fs))
self.log_fixture = self.useFixture(fixtures.FakeLogger(
level=logging.DEBUG,
format=fs))
self.useFixture(conf_fixture.ConfFixture(CONF))
self.messaging_conf = messaging_conffixture.ConfFixture(CONF)

1
nova/tests/conf_fixture.py
View File

@ -60,7 +60,6 @@ class ConfFixture(config_fixture.Config):
self.conf.set_default('connection', "sqlite://", group='database')
self.conf.set_default('sqlite_synchronous', False, group='database')
self.conf.set_default('use_ipv6', True)
self.conf.set_default('verbose', True)
self.conf.set_default('vlan_interface', 'eth0')
config.parse_args([], default_config_files=[])
self.addCleanup(utils.cleanup_dns_managers)