Update patch set 14
Patch Set 14: Code-Review-1 (3 comments) Patch-set: 14 Reviewer: Gerrit User 29244 <29244@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Code-Review=-1, 54184f7d74dc45bdc7c7bf12f43b1237f2bbdb76 Attention: {"person_ident":"Gerrit User 34429 \u003c34429@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_29244\u003e replied on the change"}
This commit is contained in:
parent
4774277b90
commit
0b6281b979
|
@ -1,5 +1,22 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "77c3fd1d_49557803",
|
||||
"filename": "/PATCHSET_LEVEL",
|
||||
"patchSetId": 14
|
||||
},
|
||||
"lineNbr": 0,
|
||||
"author": {
|
||||
"id": 29244
|
||||
},
|
||||
"writtenOn": "2023-06-22T13:17:59Z",
|
||||
"side": 1,
|
||||
"message": "tested locally, it works fine.\n-1 because I think we can remove a try/except block in the import section",
|
||||
"revId": "35c7b7f827d9bf6aa8c87dfabef53bd72580fd11",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
@ -22,6 +39,53 @@
|
|||
},
|
||||
"revId": "35c7b7f827d9bf6aa8c87dfabef53bd72580fd11",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "ec5ea779_29c99631",
|
||||
"filename": "octavia_dashboard/api/rest/barbican.py",
|
||||
"patchSetId": 14
|
||||
},
|
||||
"lineNbr": 57,
|
||||
"author": {
|
||||
"id": 29244
|
||||
},
|
||||
"writtenOn": "2023-06-22T13:17:59Z",
|
||||
"side": 1,
|
||||
"message": "we pull all the objects in our API calls in the dashboard (like the list of load balancers), so it is fine for me",
|
||||
"parentUuid": "89d4e734_9a00b7c7",
|
||||
"range": {
|
||||
"startLine": 57,
|
||||
"startChar": 18,
|
||||
"endLine": 57,
|
||||
"endChar": 50
|
||||
},
|
||||
"revId": "35c7b7f827d9bf6aa8c87dfabef53bd72580fd11",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "56bbf4f0_852a0579",
|
||||
"filename": "octavia_dashboard/sdk_connection.py",
|
||||
"patchSetId": 14
|
||||
},
|
||||
"lineNbr": 21,
|
||||
"author": {
|
||||
"id": 29244
|
||||
},
|
||||
"writtenOn": "2023-06-22T13:17:59Z",
|
||||
"side": 1,
|
||||
"message": "it seems that it was a project that is deprecated and was replaced with openstacksdk\n(https://docs.openstack.org/os-client-config/latest/)\nI think we can safely remove the try/except block here",
|
||||
"range": {
|
||||
"startLine": 21,
|
||||
"startChar": 9,
|
||||
"endLine": 21,
|
||||
"endChar": 39
|
||||
},
|
||||
"revId": "35c7b7f827d9bf6aa8c87dfabef53bd72580fd11",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue