Update patch set 32

Patch Set 32: Code-Review-1

(4 comments)

Patch-set: 32
Reviewer: Gerrit User 29244 <29244@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1, f75829a2c4b5fb0dc10b47fb875ba68012f724cb

4d6c7caaafbd99ec28b488facbfe122b78a52c6a

@@ -0,0 +1,84 @@
+{
+  "comments": [
+    {
+      "unresolved": false,
+      "key": {
+        "uuid": "2283c489_1875da1e",
+        "filename": "/PATCHSET_LEVEL",
+        "patchSetId": 32
+      },
+      "lineNbr": 0,
+      "author": {
+        "id": 29244
+      },
+      "writtenOn": "2024-04-23T11:56:18Z",
+      "side": 1,
+      "message": "small detail and questions",
+      "revId": "4d6c7caaafbd99ec28b488facbfe122b78a52c6a",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "12539dc5_f331961b",
+        "filename": "octavia_tempest_plugin/tests/act_stdby_scenario/v2/test_active_standby.py",
+        "patchSetId": 32
+      },
+      "lineNbr": 39,
+      "author": {
+        "id": 29244
+      },
+      "writtenOn": "2024-04-23T11:56:18Z",
+      "side": 1,
+      "message": "while I think it\u0027s great to add this type of annotation there, it seems unrelated to this patch",
+      "range": {
+        "startLine": 39,
+        "startChar": 4,
+        "endLine": 39,
+        "endChar": 42
+      },
+      "revId": "4d6c7caaafbd99ec28b488facbfe122b78a52c6a",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "e37e3fcd_08f298d0",
+        "filename": "octavia_tempest_plugin/tests/api/v2/test_listener.py",
+        "patchSetId": 32
+      },
+      "lineNbr": 1373,
+      "author": {
+        "id": 29244
+      },
+      "writtenOn": "2024-04-23T11:56:18Z",
+      "side": 1,
+      "message": "maybe in listener_update, we could pass the default values for the hsts fields (None, False, False) in the POST and check that the default values are crrectly set in the response, wdyt?",
+      "revId": "4d6c7caaafbd99ec28b488facbfe122b78a52c6a",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "59ae32aa_c8168bad",
+        "filename": "octavia_tempest_plugin/tests/barbican_scenario/v2/test_tls_barbican.py",
+        "patchSetId": 32
+      },
+      "lineNbr": 1242,
+      "author": {
+        "id": 29244
+      },
+      "writtenOn": "2024-04-23T11:56:18Z",
+      "side": 1,
+      "message": "why not\n\n```\nif hsts and self.mem_listener_client.is_version_supported(xx):\n```\n?",
+      "range": {
+        "startLine": 1241,
+        "startChar": 11,
+        "endLine": 1242,
+        "endChar": 42
+      },
+      "revId": "4d6c7caaafbd99ec28b488facbfe122b78a52c6a",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    }
+  ]
+}