openstack
/
octavia-tempest-plugin
Code Issues Proposed changes

Update patch set 21 

Patch Set 21:

(2 comments)

Patch-set: 21
Attention: {"person_ident":"Gerrit User 30674 \u003c30674@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_30674\u003e replied on the change"}
This commit is contained in:
Gerrit User 30674 2023-12-18 17:01:23 +00:00 committed by Gerrit Code Review
parent 54d717db02
commit 5aeac951ce
1 changed files with 35 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

35
295e4eae85c057976d0a8bd6f0d41b0111f6549b
View File

@ -85,6 +85,41 @@
"message": "I think that\noctavia_tempest_plugin/tests/scenario/v2/test_backup_members.py\nshould be renamed to\noctavia_tempest_plugin/tests/scenario/v2/test_backup_members_traffic_ops.py\n\nit would match the regex that includes it in the scenario-traffic-ops job (instead of non-traffic-ops)",
"revId": "295e4eae85c057976d0a8bd6f0d41b0111f6549b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "5e6fafce_fba2d8dd",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 21
},
"lineNbr": 0,
"author": {
"id": 30674
},
"writtenOn": "2023-12-18T17:01:23Z",
"side": 1,
"message": "recheck\nThe jobs were not triggered for whatever reason by the last comment.",
"revId": "295e4eae85c057976d0a8bd6f0d41b0111f6549b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "2a5ff7a9_55f6ad48",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 21
},
"lineNbr": 0,
"author": {
"id": 30674
},
"writtenOn": "2023-12-18T17:01:23Z",
"side": 1,
"message": "Gregory, first thanks for the review!:) \n\nMy opinion is that this is not caused by the patch. And I think it should be addressed in a different patch. \n\nI think that we\u0027re waiting for the load balancer\u0027s provisioning_status to be ACTIVE [1][2][3]. The issue in my opinion is the parallel execution of the tests. It can happen that there are two tests that are performing update",
"parentUuid": "c111f131_bc3cd2e3",
"revId": "295e4eae85c057976d0a8bd6f0d41b0111f6549b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}