Fix CI jobs

Remove centos-7 job
Mark centos-8 as non-voting
Rename ubuntu vars file to cover focal and bionic
Add functional jobs to gate as well as check
Fix linter errors

Change-Id: Iacdcda303d483617c6e94b815e2c5c1d65145f0d

files/lxc-image-fetch-url.py

@@ -116,5 +116,6 @@ def main():
     )
     print(container_url)
 
+
 if __name__ == '__main__':
     main()

tests/test.yml

@@ -129,7 +129,7 @@
         name: "{{ extra_host_package }}"
         state: present
       failed_when:
-        - extra_host_package_state.changed == true
+        - extra_host_package_state.changed
       register: extra_host_package_state
 
     - name: Check for extra package installed in lxc cache

vars/ubuntu.yml

@@ -17,14 +17,13 @@ _nspawn_hosts_container_image_url: "http://cdimage.ubuntu.com/ubuntu-base/releas
 
 _nspawn_hosts_distro_packages:
   - bridge-utils
-  - btrfs-tools
+  - btrfs-progs
   - dbus
   - dnsmasq
   - git
   - iptables
   - irqbalance
   - psmisc
-  - pxz
   - systemd-container
 
 _nspawn_container_distro_required_packages:

zuul.d/jobs.yaml

@@ -22,11 +22,6 @@
       tox_env: functional
       osa_test_repo: openstack/openstack-ansible-nspawn_container_create
 
-- job:
-    name: openstack-ansible-nspawn-container-create-centos-7
-    parent: openstack-ansible-nspawn-container-create
-    nodeset: centos-7
-
 - job:
     name: openstack-ansible-nspawn-container-create-debian-buster
     parent: openstack-ansible-nspawn-container-create

zuul.d/project.yaml

@@ -21,9 +21,16 @@
       - release-notes-jobs-python3
     check:
       jobs:
-        - openstack-ansible-nspawn-container-create-centos-7
         - openstack-ansible-nspawn-container-create-debian-buster
         - openstack-ansible-nspawn-container-create-ubuntu-bionic
+        - openstack-ansible-functional-centos-8:
+            voting: false
+    gate:
+      jobs:
+        - openstack-ansible-nspawn-container-create-debian-buster
+        - openstack-ansible-nspawn-container-create-ubuntu-bionic
+        - openstack-ansible-functional-centos-8:
+            voting: false
 
     experimental:
       jobs: