openstack
/
openstack-ansible-ops
Code Issues Proposed changes

Update patch set 3 

Patch Set 3:

(2 comments)

Patch-set: 3
This commit is contained in:
Gerrit User 538 2016-06-22 18:59:48 +00:00 committed by Gerrit Code Review
parent 060129acf1
commit 68c45b92eb
1 changed files with 34 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
6e452cfb19e6f266610090e6a73f1c61a343546b
View File

@ -17,6 +17,23 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3aaa91ec_10a299ae",
"filename": "osa-differ/osa-differ.py",
"patchSetId": 3
},
"lineNbr": 147,
"author": {
"id": 538
},
"writtenOn": "2016-06-22T18:59:48Z",
"side": 1,
"message": "I thought that made more sense too, but then flake8 said:\nE251 unexpected spaces around keyword / parameter equals",
"revId": "6e452cfb19e6f266610090e6a73f1c61a343546b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3aaa91ec_f5ca5f19",
@ -33,6 +50,23 @@
"revId": "6e452cfb19e6f266610090e6a73f1c61a343546b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3aaa91ec_f0a42dba",
"filename": "osa-differ/osa-differ.py",
"patchSetId": 3
},
"lineNbr": 208,
"author": {
"id": 538
},
"writtenOn": "2016-06-22T18:59:48Z",
"side": 1,
"message": "Good point. This thing will need some updates at that time.",
"revId": "6e452cfb19e6f266610090e6a73f1c61a343546b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}