From 151043d7f010eb35d1c9e9b5e426582e8f241bc0 Mon Sep 17 00:00:00 2001 From: Andrew Bonney Date: Tue, 2 Apr 2024 08:17:15 +0100 Subject: [PATCH] Fix designate upgrades when internal RPC version changes When upgrading from 2023.1 to 2023.2 in a HA environment, the Designate pool update command failed as it ran using an upgraded client, but made RPC calls against instances which had not been upgraded yet. This commit moves the pool update to the last play host in order to ensure that in an upgrade situation, all virtualenvs have been upgraded first to ensure no client/ server version conflicts. Change-Id: I93af581696de0913710592f9033545b87547b78a --- tasks/main.yml | 2 +- vars/main.yml | 6 ++++++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/tasks/main.yml b/tasks/main.yml index 3c24782..75cb3b9 100644 --- a/tasks/main.yml +++ b/tasks/main.yml @@ -198,7 +198,7 @@ group: "{{ designate_system_group_name }}" when: - designate_pools_yaml is defined - - _designate_is_first_play_host + - _designate_is_last_play_host notify: - Perform Designate pools update tags: diff --git a/vars/main.yml b/vars/main.yml index bf6b9b1..14989d9 100644 --- a/vars/main.yml +++ b/vars/main.yml @@ -19,6 +19,12 @@ _designate_is_first_play_host: >- inventory_hostname == (groups[designate_services['designate-api']['group']] | intersect(ansible_play_hosts)) | first) | bool }} +_designate_is_last_play_host: >- + {{ + (designate_services['designate-api']['group'] in group_names and + inventory_hostname == (groups[designate_services['designate-api']['group']] | intersect(ansible_play_hosts)) | last) | bool + }} + _designate_oslomsg_rpc_vhost_conf: >- {{ (designate_oslomsg_rpc_vhost is string) | ternary(