db_setup: refactor database setup to a common file

This patch refactors the database creation to db_setup.yml which
will eventually be managed by openstack-ansible-tests.

This also re-orders the mq_setup to be done earlier so these system
level dependencies are ready before service activation.

Change-Id: I6941e8f928dca35791b313caafe7dbf9202ed689

tasks/db_setup.yml

@@ -0,0 +1,40 @@
+---
+# Copyright 2019, VEXXHOST, Inc.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+# WARNING:
+# This file is maintained in the openstack-ansible-tests repository.
+# https://git.openstack.org/cgit/openstack/openstack-ansible-tests/tree/sync/tasks/db_setup.yml
+# If you need to modify this file, update the one in the openstack-ansible-tests
+# repository. Once it merges there, the changes will automatically be proposed to
+# all the repositories which use it.
+
+- name: Setup Database Service (MariaDB)
+  delegate_to: "{{ _oslodb_setup_host }}"
+  tags:
+    - common-mariadb
+  block:
+    - name: Create database for service
+      mysql_db:
+        name: "{{ item.name }}"
+      loop: "{{ _oslodb_databases }}"
+
+    - name: Grant access to the database for the service
+      mysql_user:
+        name: "{{ item.1.username }}"
+        password: "{{ item.1.password }}"
+        host: "{{ item.1.host | default('%') }}"
+        priv: "{{ item.0.name }}.*:{{ item.1.priv | default('ALL') }}"
+      loop: "{{ _oslodb_databases | subelements('users') }}"
+      no_log: true

tasks/main.yml

@@ -68,6 +68,40 @@
   tags:
     - manila-config
 
+- import_tasks: db_setup.yml
+  when:
+    - "manila_services['manila-api']['group'] in group_names"
+    - "inventory_hostname == ((groups[manila_services['manila-api']['group']]| intersect(ansible_play_hosts)) | list)[0]"
+  vars:
+    _oslodb_setup_host: "{{ manila_db_setup_host }}"
+    _oslodb_databases:
+      - name: "{{ manila_galera_database }}"
+        users:
+          - username: "{{ manila_galera_user }}"
+            password: "{{ manila_container_mysql_password }}"
+  tags:
+    - common-db
+    - manila-config
+
+- include_tasks: mq_setup.yml
+  when:
+    - "manila_services['manila_api']['group'] in group_names"
+    - "inventory_hostname == ((groups[manila_services['manila_api']['group']]| intersect(ansible_play_hosts)) | list)[0]"
+  vars:
+    _oslomsg_rpc_setup_host: "{{ manila_oslomsg_rpc_setup_host }}"
+    _oslomsg_rpc_userid: "{{ manila_oslomsg_rpc_userid }}"
+    _oslomsg_rpc_password: "{{ manila_oslomsg_rpc_password }}"
+    _oslomsg_rpc_vhost: "{{ manila_oslomsg_rpc_vhost }}"
+    _oslomsg_rpc_transport: "{{ manila_oslomsg_rpc_transport }}"
+    _oslomsg_notify_setup_host: "{{ manila_oslomsg_notify_setup_host }}"
+    _oslomsg_notify_userid: "{{ manila_oslomsg_notify_userid }}"
+    _oslomsg_notify_password: "{{ manila_oslomsg_notify_password }}"
+    _oslomsg_notify_vhost: "{{ manila_oslomsg_notify_vhost }}"
+    _oslomsg_notify_transport: "{{ manila_oslomsg_notify_transport }}"
+  tags:
+    - common-mq
+    - manila-config
+
 - import_tasks: manila_pre_install.yml
   tags:
     - manila-install
@@ -91,26 +125,7 @@
   tags:
     - manila-config
 
-- include_tasks: mq_setup.yml
-  when:
-    - "manila_services['manila_api']['group'] in group_names"
-    - "inventory_hostname == ((groups[manila_services['manila_api']['group']]| intersect(ansible_play_hosts)) | list)[0]"
-  vars:
-    _oslomsg_rpc_setup_host: "{{ manila_oslomsg_rpc_setup_host }}"
-    _oslomsg_rpc_userid: "{{ manila_oslomsg_rpc_userid }}"
-    _oslomsg_rpc_password: "{{ manila_oslomsg_rpc_password }}"
-    _oslomsg_rpc_vhost: "{{ manila_oslomsg_rpc_vhost }}"
-    _oslomsg_rpc_transport: "{{ manila_oslomsg_rpc_transport }}"
-    _oslomsg_notify_setup_host: "{{ manila_oslomsg_notify_setup_host }}"
-    _oslomsg_notify_userid: "{{ manila_oslomsg_notify_userid }}"
-    _oslomsg_notify_password: "{{ manila_oslomsg_notify_password }}"
-    _oslomsg_notify_vhost: "{{ manila_oslomsg_notify_vhost }}"
-    _oslomsg_notify_transport: "{{ manila_oslomsg_notify_transport }}"
-  tags:
-    - common-mq
-    - manila-config
-
-- include_tasks: manila_db_setup.yml
+- include_tasks: manila_db_sync.yml
   when:
     - groups['manila_api'] | length > 0
     - manila_services['manila_api']['group'] in group_names

tasks/manila_db_sync.yml

@@ -13,32 +13,6 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-- name: Create DB for service
-  mysql_db:
-    login_user: "{{ galera_root_user }}"
-    login_password: "{{ galera_root_password }}"
-    login_host: "{{ manila_galera_address }}"
-    name: "{{ manila_galera_database }}"
-    state: "present"
-  delegate_to: "{{ manila_db_setup_host }}"
-  no_log: true
-
-- name: Grant access to the DB for the service
-  mysql_user:
-    login_user: "{{ galera_root_user }}"
-    login_password: "{{ galera_root_password }}"
-    login_host: "{{ manila_galera_address }}"
-    name: "{{ manila_galera_user }}"
-    password: "{{ manila_container_mysql_password }}"
-    host: "{{ item }}"
-    state: "present"
-    priv: "{{ manila_galera_database }}.*:ALL"
-  delegate_to: "{{ manila_db_setup_host }}"
-  with_items:
-    - "localhost"
-    - "%"
-  no_log: true
-
 - name: Perform a manila DB sync
   command: "{{ manila_bin }}/manila-manage db sync"
   become: yes