From a05457498ff2ab6a8a6105b215826678c40c3afe Mon Sep 17 00:00:00 2001 From: kaiokassiano Date: Fri, 10 Aug 2018 11:44:59 -0300 Subject: [PATCH] Cleanup unused pip packages The virtualenv shouldn't be installed individually by a role, therefore should be removed. The other packages are not really necessary since they are remnant from the role creation (copied and pasted from another role). Thus we also remove the task related to the install of those. Change-Id: I76b870ae54602a0c7f99774b250c447c748fb6aa --- defaults/main.yml | 6 ------ tasks/monasca_agent_install.yml | 12 ------------ 2 files changed, 18 deletions(-) diff --git a/defaults/main.yml b/defaults/main.yml index 91d7ba0..79d8e65 100644 --- a/defaults/main.yml +++ b/defaults/main.yml @@ -275,12 +275,6 @@ monasca_agent_plugins: - name: "ntp" where: "hosts" -## Monasca-agent packages that must be installed before anything else -monasca_agent_requires_pip_packages: - - virtualenv - - python-keystoneclient - - httplib2 - monasca_agent_pip_packages: - keystoneauth1 - libvirt-python diff --git a/tasks/monasca_agent_install.yml b/tasks/monasca_agent_install.yml index feee4f1..856381e 100644 --- a/tasks/monasca_agent_install.yml +++ b/tasks/monasca_agent_install.yml @@ -32,18 +32,6 @@ when: - monasca_agent_developer_mode | bool -- name: Install requires pip packages - pip: - name: "{{ monasca_agent_requires_pip_packages }}" - state: "{{ monasca_agent_pip_package_state }}" - extra_args: >- - {{ (pip_install_upper_constraints is defined) | ternary('--constraint ' + pip_install_upper_constraints | default(''),'') }} - {{ pip_install_options | default('') }} - register: install_packages - until: install_packages is success - retries: 5 - delay: 2 - - name: Retrieve checksum for venv download uri: url: "{{ monasca_agent_venv_download_url | replace('tgz', 'checksum') }}"