Add online_data_migrations for placement

According to the placement upgrade process, online_data_migrations
should be triggered right after upgrading database schema
and placement services on all controller nodes [1]

We also replace usage of  `need_service_restart` local fact
with `need_online_data_migrations` as first one is never actually used.

[1] https://docs.openstack.org/placement/latest/cli/placement-manage.html#placement-database

Change-Id: I430ea45fe321440d832a0a90747b80f5d197f073
This commit is contained in:
Dmitriy Rabotyagov 2023-08-21 18:18:26 +02:00
parent 8dc0edec53
commit e32db7ae75
4 changed files with 67 additions and 5 deletions

View File

@ -154,3 +154,14 @@
- name: Flush handlers
meta: flush_handlers
- name: Including placement_db_post_setup tasks
include_tasks: placement_db_post_setup.yml
args:
apply:
tags:
- placement-config
when:
- "_placement_is_last_play_host"
tags:
- placement-config

View File

@ -0,0 +1,45 @@
---
# Copyright 2023, Cleura AB.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
- name: Refresh local facts
setup:
filter: ansible_local
gather_subset: "!all"
- name: Perform a Placement DB online migrations
command: "{{ placement_bin }}/placement-manage db online_data_migrations"
become: true
become_user: "{{ placement_system_user_name }}"
changed_when: false
retries: 5
delay: 3
until: "data_migrations.rc in [0, 2]"
register: data_migrations
when:
- "ansible_local['openstack_ansible']['placement']['need_online_data_migrations'] | bool"
- _placement_is_last_play_host
- name: Disable the online migrations requirement
delegate_to: "{{ item }}"
ini_file:
dest: "/etc/ansible/facts.d/openstack_ansible.fact"
section: placement
option: need_online_data_migrations
value: False
mode: "0644"
with_items: "{{ groups[placement_services['placement-api']['group']] }}"
when:
- data_migrations is not skipped
- data_migrations is succeeded

View File

@ -50,7 +50,7 @@
venv_pip_packages: "{{ placement_pip_packages }}"
venv_facts_when_changed:
- section: "placement"
option: "need_service_restart"
option: "need_online_data_migrations"
value: True
- section: "placement"
option: "venv_tag"
@ -61,11 +61,11 @@
ini_file:
dest: "/etc/ansible/facts.d/openstack_ansible.fact"
section: "placement"
option: "need_service_restart"
option: "need_online_data_migrations"
value: true
mode: "0644"
when: (install_packages is changed) or
('need_service_restart' not in ansible_local['openstack_ansible']['placement'])
('need_online_data_migrations' not in ansible_local['openstack_ansible']['placement'])
- name: Run the systemd service role
include_role:

View File

@ -15,9 +15,15 @@
_placement_is_first_play_host: >-
{{
(placement_services['placement-api']['group'] in group_names and
inventory_hostname == (groups[placement_services['placement-api']['group']] | intersect(ansible_play_hosts)) | first) | bool
(placement_services['placement-api']['group'] in group_names and inventory_hostname == (
groups[placement_services['placement-api']['group']] | intersect(ansible_play_hosts)) | first) | bool
}}
_placement_is_last_play_host: >-
{{
(placement_services['placement-api']['group'] in group_names and inventory_hostname == (
groups[placement_services['placement-api']['group']] | intersect(ansible_play_hosts)) | last) | bool
}}
# Compile a list of the services on a host based on whether
# the host is in the host group and the service is enabled.