openstack
/
openstack-ansible-os_tempest
Code Issues Proposed changes

Do not use a role scoped variable for role include condition 

The var tempest_plugin_install_source is defined within the
os_tempest role so if it is used in the condition that includes
the python_venv_build role, it must be in scope for the python venv
build handler which runs in the outer containing playbook, and
this fails with a var not found error.

Change-Id: I7d1fd3b7d06d3a0c6d86750ed36cbe858190f87e
This commit is contained in:
Jonathan Rosser 2019-08-16 18:37:26 +01:00
parent 3640f71679
commit f4b1c94de9
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
tasks/tempest_install_source.yml
View File

@ -28,7 +28,11 @@
- section: "tempest"
option: "venv_tag"
value: "{{ tempest_venv_tag }}"
when: not tempest_plugin_install_source
# Note(jrosser) this task can be conditional on tempest_plugin_install_source
# but then that variable must be in scope when the handler inside python_venv_build
# runs, so it is better to duplicate the underlying condition logic
# when: not tempest_plugin_install_source
when: not "{{ ((tempest_install_method | default('source') == 'distro') and (ansible_os_family | lower == 'debian')) | bool }}"
- name: Get tempest plugins from git
git: