openstack
/
openstack-ansible-pip_install
Code Issues Proposed changes

Fix misspelled registered variable name in conditional 

add_uca_repo -> uca_add_repo

Commit c68db4e6 refactored a task into two tasks and in the process
misspelled the variable registered in the first task within the
condition of the second task.  The undefined state of the misspelled
variable was unintentionally handled in this case because under
different circumstances the variable is expected to be undefined (ie
when the first task is skipped).

Change-Id: I73b7c5ab4de50df0b341fc3c02675e6c23b2b3da
Signed-off-by: Corey Wright <corey.wright@rackspace.com>
This commit is contained in:
Corey Wright 2018-03-29 11:59:23 -05:00
parent c68db4e674
commit 9195bc7066
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tasks/pre_install_apt.yml
View File

@ -87,7 +87,7 @@
apt:
update_cache: yes
when:
- (add_uca_repo is mapping and add_uca_repo | changed) or
- (uca_add_repo is mapping and uca_add_repo | changed) or
(use_external_repo_apt is mapping and use_external_repo_apt | changed)
register: update_apt_cache
until: update_apt_cache | success