From 0e03f46a2ebb0ffc6f12384f19ec1184434e7a09 Mon Sep 17 00:00:00 2001 From: Dave Wilde Date: Tue, 17 Jul 2018 14:07:41 -0500 Subject: [PATCH] Update get-pip to version 3.3 Version 3.2 has a bug with it on some systems that can result in the following stacktrace: [ http://paste.openstack.org/show/726064 ]. To correct this issue the version of the get-pip script has been set to 3.3 which does not suffer from the same issue. Change-Id: I61a7234dc4fbde1b9319874d82fe33578f490abc Partial-Bug: 1779534 (cherry picked from commit 184dbb8e18973a8baf69d203c0b159367cb1ff8e) --- group_vars/all/pip.yml | 2 +- playbooks/common-tasks/set-pip-upstream-url.yml | 6 +++--- scripts/scripts-library.sh | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/group_vars/all/pip.yml b/group_vars/all/pip.yml index b3967a1431..70e0c54b11 100644 --- a/group_vars/all/pip.yml +++ b/group_vars/all/pip.yml @@ -23,4 +23,4 @@ pip_lock_to_internal_repo: "{{ (pip_links | length) >= 1 }}" pip_install_upper_constraints: "{{ repo_release_path }}/requirements_absolute_requirements.txt" # The URL to retrieve the get-pip.py installation script -pip_upstream_url: "{{ (pip_offline_install | bool) | ternary('https://bootstrap.pypa.io/3.2/get-pip.py', repo_release_path ~ '/get-pip.py') }}" +pip_upstream_url: "{{ (pip_offline_install | bool) | ternary('https://bootstrap.pypa.io/3.3/get-pip.py', repo_release_path ~ '/get-pip.py') }}" diff --git a/playbooks/common-tasks/set-pip-upstream-url.yml b/playbooks/common-tasks/set-pip-upstream-url.yml index 0f1656167b..0eb015b628 100644 --- a/playbooks/common-tasks/set-pip-upstream-url.yml +++ b/playbooks/common-tasks/set-pip-upstream-url.yml @@ -23,15 +23,15 @@ method: "HEAD" register: _repo_data_check failed_when: false - when: pip_upstream_url != "https://bootstrap.pypa.io/3.2/get-pip.py" + when: pip_upstream_url != "https://bootstrap.pypa.io/3.3/get-pip.py" tags: - common-pip - name: Set pip upstream URL set_fact: - pip_upstream_url: "https://bootstrap.pypa.io/3.2/get-pip.py" + pip_upstream_url: "https://bootstrap.pypa.io/3.3/get-pip.py" when: - - pip_upstream_url != "https://bootstrap.pypa.io/3.2/get-pip.py" + - pip_upstream_url != "https://bootstrap.pypa.io/3.3/get-pip.py" - (_repo_data_check.status | default(503)) != 200 tags: - common-pip diff --git a/scripts/scripts-library.sh b/scripts/scripts-library.sh index 12db8bdfd4..dbd11d1a12 100755 --- a/scripts/scripts-library.sh +++ b/scripts/scripts-library.sh @@ -321,8 +321,8 @@ function get_pip { ${GETPIP_CMD} ${GET_PIP_URL} > ${GETPIP_FILE} else # Otherwise, try the two standard URL's - ${GETPIP_CMD} https://bootstrap.pypa.io/3.2/get-pip.py > ${GETPIP_FILE}\ - || ${GETPIP_CMD} https://raw.githubusercontent.com/pypa/get-pip/master/3.2/get-pip.py > ${GETPIP_FILE} + ${GETPIP_CMD} https://bootstrap.pypa.io/3.3/get-pip.py > ${GETPIP_FILE}\ + || ${GETPIP_CMD} https://raw.githubusercontent.com/pypa/get-pip/master/3.3/get-pip.py > ${GETPIP_FILE} fi ${GETPIP_PYTHON_EXEC_PATH} ${GETPIP_FILE} \