From c72ab70202a341fa631b56795e9115971abb66e5 Mon Sep 17 00:00:00 2001
From: Masayuki Igawa <masayuki@igawa.me>
Date: Sun, 19 Mar 2017 16:34:04 +0800
Subject: [PATCH] Fix ratio to percent on failure rate graphs

This commit fixes the ratio values to percent on failure rate graphs. We
already use percents in many graphs and users are familiar with percents
rather than ratio.

Change-Id: I056b62b215230b4666401eabace42cac7e68201d
Closes-Bug: #1674066
---
 app/js/controllers/grouped-runs.js         | 2 +-
 app/js/controllers/home.js                 | 2 +-
 app/js/controllers/job.js                  | 2 +-
 app/views/grouped-runs.html                | 2 +-
 app/views/home.html                        | 2 +-
 app/views/job.html                         | 2 +-
 test/unit/controllers/grouped_runs_spec.js | 2 +-
 test/unit/controllers/home_spec.js         | 4 ++--
 test/unit/controllers/job_spec.js          | 2 +-
 9 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/app/js/controllers/grouped-runs.js b/app/js/controllers/grouped-runs.js
index 0224de1c..5ef2b8f3 100644
--- a/app/js/controllers/grouped-runs.js
+++ b/app/js/controllers/grouped-runs.js
@@ -110,7 +110,7 @@ function GroupedRunsController(
 
       failRateEntries.push({
         x: new Date(timedelta.datetime).getTime(),
-        y: failRate
+        y: failRate * 100
       });
     });
 
diff --git a/app/js/controllers/home.js b/app/js/controllers/home.js
index 3139c51d..e1a780de 100644
--- a/app/js/controllers/home.js
+++ b/app/js/controllers/home.js
@@ -69,7 +69,7 @@ function HomeController(
     angular.forEach(dateStats, function(stats) {
       entries.passes.push(generateChartData(stats.date, stats.metrics.passes));
       entries.failures.push(generateChartData(stats.date, stats.metrics.failures));
-      entries.failRate.push(generateChartData(stats.date, stats.metrics.failRate));
+      entries.failRate.push(generateChartData(stats.date, stats.metrics.failRate * 100));
     });
     entries.passes = entries.passes.sort(byDate);
     entries.failures = entries.failures.sort(byDate);
diff --git a/app/js/controllers/job.js b/app/js/controllers/job.js
index 2975bd8e..0f99b425 100644
--- a/app/js/controllers/job.js
+++ b/app/js/controllers/job.js
@@ -131,7 +131,7 @@ function JobController(
       failRate = totalFail / (totalFail + totalPass) || DEFAULT_FAIL_RATE;
       failRateEntries.push({
         x: new Date(date).getTime(),
-        y: failRate
+        y: failRate * 100
       });
 
       skipEntries.push({
diff --git a/app/views/grouped-runs.html b/app/views/grouped-runs.html
index 902be467..5bc67c1c 100644
--- a/app/views/grouped-runs.html
+++ b/app/views/grouped-runs.html
@@ -80,7 +80,7 @@
                                     granular-format="%x %X"></chart-axis>
                         <chart-axis name="y" opposes="x" type="linear"
                                     path=".y" align="left" orient="vertical"
-                                    domain="[0, 1]" draw="true"
+                                    domain="[0, 100]" draw="true"
                                     granular-format=".3f"></chart-axis>
 
                         <chart-dataset name="rate"
diff --git a/app/views/home.html b/app/views/home.html
index 69bae608..e08989af 100644
--- a/app/views/home.html
+++ b/app/views/home.html
@@ -83,7 +83,7 @@
                                     granular-format="%x %X"></chart-axis>
                         <chart-axis name="y" type="linear" path=".y" opposes="x"
                                     align="left" orient="vertical"
-                                    domain="[0, 1]" draw="true"
+                                    domain="[0, 100]" draw="true"
                                     granular-format=".3f"></chart-axis>
 
                         <chart-dataset name="rate"
diff --git a/app/views/job.html b/app/views/job.html
index ec852dba..a0e8e985 100644
--- a/app/views/job.html
+++ b/app/views/job.html
@@ -87,7 +87,7 @@
                                     granular-format="%x %X"></chart-axis>
                         <chart-axis name="y" opposes="x" type="linear"
                                     path=".y" align="left" orient="vertical"
-                                    domain="[0, 1]" draw="true"
+                                    domain="[0, 100]" draw="true"
                                     granular-format=".3f"></chart-axis>
 
                         <chart-dataset name="rate"
diff --git a/test/unit/controllers/grouped_runs_spec.js b/test/unit/controllers/grouped_runs_spec.js
index df5b3d59..49bce7bd 100644
--- a/test/unit/controllers/grouped_runs_spec.js
+++ b/test/unit/controllers/grouped_runs_spec.js
@@ -155,7 +155,7 @@ describe('GroupedRunsController', function() {
 
     expect(groupedRunsController.failRates).toEqual([{
       x: 1416355200000,
-      y: 0.023529411764705883
+      y: 2.3529411764705883
     }]);
   });
 });
diff --git a/test/unit/controllers/home_spec.js b/test/unit/controllers/home_spec.js
index d1979dec..1231ca4e 100644
--- a/test/unit/controllers/home_spec.js
+++ b/test/unit/controllers/home_spec.js
@@ -70,7 +70,7 @@ describe('HomeController', function() {
     beforeEach(function() {
       var date = new Date('2015-10-01T20:00:00.000Z');
       timestamp = date.getTime();
-      var metrics = { passes: 3, failures: 4, failRate: 0.57 };
+      var metrics = { passes: 3, failures: 4, failRate: 56.99999999999999 };
       var stats = [{ date: date, metrics: metrics }];
       projectService.getStatsByDate = function() { return stats; };
       homeController.loadData();
@@ -82,7 +82,7 @@ describe('HomeController', function() {
     });
 
     it('should contain data for failure rate', function() {
-      expect(homeController.failRate).toEqual([{ x: 1443729600000, y: 0.57 }]);
+      expect(homeController.failRate).toEqual([{ x: 1443729600000, y: 5699.999999999999 }]);
     });
   });
 
diff --git a/test/unit/controllers/job_spec.js b/test/unit/controllers/job_spec.js
index 3a098343..2a30f057 100644
--- a/test/unit/controllers/job_spec.js
+++ b/test/unit/controllers/job_spec.js
@@ -147,7 +147,7 @@ describe('JobController', function() {
 
     expect(jobController.failRates).toEqual([{
       x: 1416358800000,
-      y: 0.018867924528301886
+      y: 1.8867924528301887
     }]);
   });