openstack
/
openstack
Code Issues Proposed changes

Update git submodules 

* Update heat-dashboard from branch 'master'
  - Merge "Remove six usage (2/2)"
  - Remove six usage (2/2)
    
    This repo does not support Python 2 anymore, so we don't need
    six for compatibility between Python2 and 3,
    convert six usage to Python 3 code.
    
    This changes urllib usage.
    
    mock.patch usage in heat_dashboard/test/tests/api/test_heat.py
    is modified to cope with the mix usage of urllib from python3 (in
    heat-dashboard) and six.moves.urllib (in heatclient).
    In the case of the mix usage, patching urllib.request.urlopen() only
    does not work as urllib.request.urlopen() is not called after
    resolving a lazy loading in six and the resolved object is
    six.moves.urllib.request is called. The previous code depends on
    the behavior in heatclient read_url_content() and the method should
    be mocked instead. Considering this, mocking in api/test_heat.py
    is modified to mock direct methods called in the heat-dashboard code.
    
    Co-Authored-By: Akihiro Motoki <amotoki@gmail.com>
    Change-Id: Icf3f889770242b02023fe22c405cfa2d823581a5
    Needed-By: https://review.opendev.org/701743
This commit is contained in:
Zuul 2020-01-22 06:20:52 +00:00 committed by Gerrit Code Review
parent e2ed718934
commit 0098a79850
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
heat-dashboard

@ -1 +1 @@
Subproject commit 53265863803dcb4760468570dad5161ccf1ac7a4
Subproject commit 78421908513eec5366fda3081e47c085ad2f89d0