openstack
/
openstack
Code Issues Proposed changes

Update git submodules 

* Update neutron from branch 'master'
  to 95e4e3b092065135bcaf21b43d532b248dace565
  - Merge "Use oslo_service's SignalHandler for signals"
  - Use oslo_service's SignalHandler for signals
    
    When Neutron is killed with SIGTERM (like via systemctl), when using
    ML2/OVN neutron workers do not exit and instead are eventually killed
    with SIGKILL when the graceful timeout is reached (often around 1
    minute).
    
    This is happening due to the signal handlers for SIGTERM. There are
    multiple issues.
    
    1) oslo_service, ml2/ovn mech_driver, and ml2/ovo_rpc.py all call
       signal.signal(signal.SIGTERM, ...) overwriting each others signal
       handlers.
    2) SIGTERM is handled in the main thread, and running blocking code
       there causes AssertionErrors in eventlet which also prevents the
       process from exiting.
    3) The ml2/ovn cleanup code doesn't cause the process to end, so it
       interrupts the killing of the process.
    
    oslo_service has a singleton SignalHandler class that solves all of
    these issues
    
    Closes-Bug: #2056366
    Depends-On: https://review.opendev.org/c/openstack/oslo.service/+/911627
    Change-Id: I730a12746bceaa744c658854e38439420efc4629
    Signed-off-by: Terry Wilson <twilson@redhat.com>
This commit is contained in:
Zuul 2024-03-20 00:21:52 +00:00 committed by Gerrit Code Review
parent e1197c8387
commit 08f85a9211
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
neutron

@ -1 +1 @@
Subproject commit 1b3bc34f670dce5e1292a787b61723901a9cbbcf
Subproject commit 95e4e3b092065135bcaf21b43d532b248dace565