openstack
/
openstack
Code Issues Proposed changes

Update git submodules 

* Update cinder from branch 'master'
  to c8c4fc953c4a563ed2295efaf82c75b52de06a2c
  - Add installation of mypy stubs packages
    
    The cinder-mypy job is failing because library stubs aren't installed
    for requests [0].  Modify the mypywrap.sh to accept options specified
    in an environment variable named OS_MYPY_OPTS to the mypy invocation,
    and set this var in tox.ini.
    
    The value is "--install-types --non-interactive" which is suitable for
    CI purposes, and seems to make sense for local tox use as well [1].
    The downside is it basically runs mypy twice, once to determine
    whether there are any library stubs missing and then install them, and
    againto do the actual check.  If we don't want this setting in
    tox.ini, we can move it to .zuul.yaml for the cinder-mypy job run.
    
    Also, update the version of mypy in test-requirements to a version
    that supports the above options.
    
    And, run mypy in its own env (instead of reusing pep8) so that the
    tox logs are preserved during CI runs.
    
    [0] https://zuul.opendev.org/t/openstack/build/b66ee6c21e594940941585b0e9e5082a
    [1] https://mypy.readthedocs.io/en/stable/running_mypy.html#library-stubs-not-installed
    
    Change-Id: Id69cb519ee7300b33ff087de4e7d46cdad67d162
This commit is contained in:
Brian Rosmaita 2021-07-15 13:21:45 -04:00 committed by Gerrit Code Review
parent 34f79cebee
commit 212582586e
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
cinder

@ -1 +1 @@
Subproject commit 0570b168e2a444af0d39750638590db0ebcee1a4
Subproject commit c8c4fc953c4a563ed2295efaf82c75b52de06a2c