openstack
/
openstack
Code Issues Proposed changes

Update git submodules 

* Update puppet-openstackid from branch 'master'
  - Disable legacy nodejs symlinks
    
    We currently setup a symlink loop between /usr/bin/node and
    /usr/bin/nodejs. This seems to happen due to a mismatch in expectations
    between nodesource packaging and our nodejs puppet module. Thankfully
    the puppet module allows us to disable the symlinking behavior [0].
    We've successfully used this method on the etherpad servers so apply it
    to openstackid as well.
    
    [0] https://github.com/voxpupuli/puppet-nodejs/tree/v2.3.0#legacy_debian_symlinks
    
    Debugging notes:
    
    Symlink loop:
    
      clarkb@openstackid-dev01:~$ ls -al /usr/bin/node
      lrwxrwxrwx 1 root root 15 Mar 18 23:54 /usr/bin/node -> /usr/bin/nodejs
      clarkb@openstackid-dev01:~$ ls -al /usr/bin/nodejs
      lrwxrwxrwx 1 root root 24 Mar 18 23:32 /usr/bin/nodejs -> /etc/alternatives/nodejs
      clarkb@openstackid-dev01:~$ ls -al /etc/alternatives/nodejs
      lrwxrwxrwx 1 root root 13 Mar 18 23:32 /etc/alternatives/nodejs -> /usr/bin/node
    
    Package contents:
    
      clarkb@openstackid-dev01:~$ dpkg -L nodejs | grep /usr/bin
      /usr/bin
      /usr/bin/node
      /usr/bin/npx
      /usr/bin/npm
    
    Puppet logs:
    
      Mar 18 23:54:39 openstackid-dev01 puppet-user[19866]: (/Stage[main]/Nodejs::Install/File[/usr/bin/node]/ensure) ensure changed 'file' to 'link'
      Mar 18 23:54:39 openstackid-dev01 puppet-user[19866]: (/Stage[main]/Nodejs::Install/File[/usr/share/man/man1/node.1.gz]/ensure) ensure changed 'file' to 'link'
    
    Change-Id: Ib77b851e12a4f94b5853b1b9e981f898c0ad36f1
This commit is contained in:
Clark Boylan 2019-03-20 10:54:22 -07:00 committed by Gerrit Code Review
parent 628ba8eba5
commit 2859ec0538
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
puppet-openstackid

@ -1 +1 @@
Subproject commit e38fbc10c072bbb588cb286f50594f42a503854e
Subproject commit d53f72407e031cbf65b16f6a9c98edd923500a72