openstack
/
openstack
Code Issues Proposed changes

Update git submodules 

* Update puppet-graphite from branch 'master'
  - Fix up log rotation
    
    Turns out this is a bit of a pain, and we found out via a full disk.
    
    Firstly, carbon wants to rotate it's own log files, but doesn't
    compress or cleanup.  Disable this with ENABLE_LOGROTATION=False,
    which has been around for a while.  This is copied from the upstream
    example config.
    
    Secondly, we were missing the console.log file.  Change the rotate to
    just one for "*.log", and also add "sharedscripts" so the post-rotate
    is only run once per rotation of all files.
    
    Thirdly, copytruncate doesn't work [2].  It needs to be "nocreate";
    the file is moved and carbon starts a new one (as suggested by the
    config comment).  This is updated in the combined rotate section.
    
    [1] https://github.com/graphite-project/carbon/pull/68
    [2] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=733856
    
    Change-Id: I946bb728971db79a2f4d08f2787c0768b958fb53
This commit is contained in:
Ian Wienand 2018-02-07 10:28:02 +11:00 committed by Gerrit Code Review
parent f4d54fc36b
commit 4f430c8f2a
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
puppet-graphite

@ -1 +1 @@
Subproject commit 4a30897c0575c41c03f5d52593d250bb073483f4
Subproject commit dfc94e4fd9161bed881b8b134cb77c7acc02a28c