openstack
/
openstack
Code Issues Proposed changes

Update git submodules 

* Update oslo.policy from branch 'master'
  to d3185debdbb7aa254ad4ce2acc38c9a34908e44a
  - Merge "Add documentation parameters for DeprecatedRule"
  - Add documentation parameters for DeprecatedRule
    
    Currently, the way you replace a rule with another rule is by using the
    'deprecated_rule' parameter of '(Documented)RuleDefault'. For example:
    
      deprecated_rule = policy.DeprecatedRule(
          name='foo:bar',
          check_str='role:bazz'
      )
    
      policy.RuleDefault(
          name='foo:create_bar',
          check_str='role:bang',
          description='Create a bar.',
          deprecated_rule=deprecated_rule,
          deprecated_reason='foo:bar has been replaced by foo:create_bar',
          deprecated_since='N',
      )
    
    In this instance, we're stating that the 'foo:create_bar' policy
    replaces the 'foo:bar' policy and we've used (and indeed have to use, to
    avoid a 'ValueError') the 'deprecated_reason' and 'deprecated_since'
    parameters on the **new** rule to illustrate why. This is confusing. The
    new rule clearly isn't the one that's deprecated, so why are we stating
    the 'deprecated_reason' and 'deprecated_since' there? We can clarify
    this by instead specifying the reason and timeline on the deprecated
    rule, like so:
    
      deprecated_rule = policy.DeprecatedRule(
          name='foo:bar',
          check_str='role:bazz'
          deprecated_reason='foo:bar has been replaced by foo:create_bar',
          deprecated_since='N',
      )
    
      policy.RuleDefault(
          name='foo:create_bar',
          check_str='role:bang',
          description='Create a bar.',
          deprecated_rule=deprecated_rule,
      )
    
    Add support for this, with appropriate warnings to nudge people over to
    the new, improved way of doing things eventually.
    
    Change-Id: Ie4809c7749242bd092a2677b7545ef281735d984
    Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
This commit is contained in:
Zuul 2021-02-17 15:19:13 +00:00 committed by Gerrit Code Review
parent 4ab766ea94
commit 6271f8aa1e
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
oslo.policy

@ -1 +1 @@
Subproject commit 66d6ef33ae83ec0b640e11ecfc2b02bc51258776
Subproject commit d3185debdbb7aa254ad4ce2acc38c9a34908e44a