openstack
/
openstack
Code Issues Proposed changes

Update git submodules 

* Update openstack-helm from branch 'master'
  to 5e19791931119e7f72fef4470eb77cf76012c214
  - Merge "upgrading umbrella w/o changes has no app changes"
  - upgrading umbrella w/o changes has no app changes
    
    If a Helm upgrade is performed on the OpenStack Umbrella chart using
    the exact same configuration as the first release, then it's expected
    for no DaemonSets, Deployments, or StatefulSets to be updated.
    This did not work as expected.
    
    A few changes were required to support this desired behavior:
    1. Update glance's configmap-etc.yaml to trim whitespace and convert
       YAML comment to Helm template comment. Before this change, Helm
       rendered the template with the YAML comment and a newline for the
       install phase. On upgrades, Helm rendered the template without the
       YAML comment and newline causing the hash of configmap-etc to change,
       thus causing the glance-api Deployment to update.
    2. Update openstack.sh script to create a randomly generated memcache
       secret for glance. Without this change, the glance-api deployment
       changes each time since Helm randomly generates a new memcache
       secret if not provided.
    
    This behavior is enforced via a new test script,
    validate-umbrella-upgrade-no-side-effects.sh.
    
    The following jobs are always recreated due to hooks:
    - keystone-bootstrap
    - keystone-credential-setup
    - keystone-db-init
    - keystone-db-sync
    - keystone-domain-manage
    - keystone-fernet-setup
    - keystone-rabbit-init
    - rabbitmq-cluster-wait
    
    Some Jobs are created via CronJobs and could be created during
    validation. So far, heat-engine-cleaner has been seen, but others
    could be caught too.
    
    So the validation script ignores these pod changes by ignoring if
    Jobs were recreated. Plus Jobs being recreated should not impact
    the OpenStack deployment.
    
    Change-Id: Iffaa346d814b8d0a3e2292849943219f70d50a23
This commit is contained in:
Zuul 2022-07-04 06:22:45 +00:00 committed by Gerrit Code Review
parent 5672269c3a
commit 6eab381442
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
openstack-helm

@ -1 +1 @@
Subproject commit 7b05f28e827a2215fe5d4f413d9e9f06c9dae46f
Subproject commit 5e19791931119e7f72fef4470eb77cf76012c214