openstack
/
openstack
Code Issues Proposed changes

Update git submodules 

* Update openstack-ansible from branch 'master'
  - Merge "Fix KeyError raised when max hostname length exceeded"
  - Fix KeyError raised when max hostname length exceeded
    
    The function osa_toolkit.generate._add_container_hosts contains a bug in
    the code used to check if provided hostnames have exceeded their max
    allowed length. The logic used to perform this check depends on the
    `is_metal` flag within each container's properties. Unfortunately the
    `is_metal` flag is accessed within the `properties` dictionary using
    bracket notation rather than the safer `dict.get` method, causing a
    `KeyError` to be raised when a host's properties dictionary does not
    contain the `is_metal` flag.
    
    It is not expected that a `KeyError` would be raised in the function if
    hostnames have exceeded their max length. It is instead expected that a
    `SystemExit` exception would be raised warning the user of their invalid
    hostname(s).
    
    This bug will impacts deployments where hostnames actually do exceed the
    max allowed length due to the short circuit logic used in the if-elif
    tree.
    
    Closes-Bug: #1886905
    
    Change-Id: Ic1acfea71f27f94e277aa443f0a53ef16b4eb417
This commit is contained in:
Zuul 2020-07-10 09:58:42 +00:00 committed by Gerrit Code Review
parent c21fb6be0e
commit 6f680c2ff8
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
openstack-ansible

@ -1 +1 @@
Subproject commit 6430540a4a0c909719bdddda0152195fbae6dc31
Subproject commit 8fa414e1f8e2528c2bcaae706d1a4b893b591c04