openstack
/
openstack
Code Issues Proposed changes

Update git submodules 

* Update os-brick from branch 'master'
  to 00caa73776d9987103f9023a1c4e9c643fa77039
  - RBD: Improve close and flush in IOWrapper
    
    On Change-Id Ib3b066a7da071b1c2de78a1a4e569676539bd335 we improved the
    RBDVolumeIOWrapper's flush and close methods, and this patch improves
    them even further.
    
    If the IOWrapper's close is not explicitly called and it's just
    dereferenced (happens in unit tests) then during Garbage Collection the
    wrapped image may be destroyed before the wrapper, which would trigger
    the image being closed without the wrapper knowing, so when the wrapper
    gets destroyed it will fail because it calls its close method, which
    calls its flush, which calls the underlying image's flush, which will
    fail because the underlying image was already closed.
    
    We need to check if the underlying image has already being flushed
    before calling the flush.
    
    Calling the underlying close method for the Image or IOWrapper classes
    is not a problem because they are idempotent.
    
    Change-Id: Ib5a517d58427df0d1d1b22ad3dc66f673da147fe
This commit is contained in:
Gorka Eguileor 2023-08-24 00:32:26 +02:00 committed by Gerrit Code Review
parent ee29d4c2b3
commit 7997ed8335
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
os-brick

@ -1 +1 @@
Subproject commit 0a5d4c1506a9b85dfe0afa6796e1b94d2b3cc81a
Subproject commit 00caa73776d9987103f9023a1c4e9c643fa77039