openstack
/
openstack
Code Issues Proposed changes

Update git submodules 

* Update cinder from branch 'master'
  to 51fd9aeed4d35c480edb301dcd378930cea31ae4
  - Merge "Delete attachment on remove_export failure"
  - Delete attachment on remove_export failure
    
    When deleting an attachment, if the driver's remove_export or the
    detach_volume method call fails in the cinder driver, then the
    attachment status is changed to error_detaching but the REST API call
    doesn't fail.
    
    The end result is:
    - Volume status is "available"
    - Volume attach_status is "detached"
    - There is a volume_attachment record for the volume
    - The volume may still be exported in the backend
    
    The volume still being exported in the storage array is not a problem,
    since the next attach-detach cycle will give it another opportunity for
    it to succeed, and we also do the export on volume deletion.
    
    So in the end leaving the attachment in error_detaching status doesn't
    have any use and creates confusion.
    
    This patch removes the attachment record when on an attachment delete
    request if the error happens on remove_export or detach_volume calls.
    
    This doesn't change how the REST API attachment delete operation
    behaves, the change is that there will not be a leftover attachment
    record with the volume in available and detached status.
    
    Closes-Bug: #1935057
    Change-Id: I442a42b0c098775935a799876ad8efbe141829ad
This commit is contained in:
Zuul 2021-09-23 23:14:10 +00:00 committed by Gerrit Code Review
parent 5efab4564e
commit 85f753b714
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
cinder

@ -1 +1 @@
Subproject commit fad55bc74d41a905067775043d17b3949239f303
Subproject commit 51fd9aeed4d35c480edb301dcd378930cea31ae4