openstack
/
openstack
Code Issues Proposed changes

Updated openstack/openstack 

Project: openstack/oslo.config  bb8846a3ab0dc92f31a343b7493ada533624a490

Fixing HostName and adding support for HostAddress

When config options in different projects use IPOpt as the opt's
type, it restricts operators to only IP addresses.
When the opt is set to HostnameOpt type, currently even an
incomplete or invalid IP passes as a valid hostname. Also, currently
HostnameOpt does not make sure that there is a presense of at least one
non-numeric character in the provided host name.

According to RFC 1123, (https://tools.ietf.org/html/rfc1123),
a valid host name can never have the dotted-decimal form #.#.#.#,
since at least the highest-level component label will be alphabetic.

This patch fixes the existing Hostname Opt to abide by the stated RFC
and also adds a new opt type that would enable operators to provide
either a hostname or an IP and at the same time perform checks on
both IPOpt type and HostnameOpt type, by setting opt type to
"HostAddressOpt" type. This would ensure that an invalid IP does
not pass as a valid hostname and at the same time retains the rules
required to be followed for the validation of an acceptable hostname.

Change-Id: I77bdb64b7e6e56ce761d76696bc4448a9bd325eb
Closes-Bug: #1619044
Closes-Bug: #1615028
This commit is contained in:
Jenkins 2016-12-07 06:35:28 +00:00 committed by Gerrit Code Review
parent 84a8288272
commit a4ec6b9aab
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
oslo.config

@ -1 +1 @@
Subproject commit aed4dcd893e9c3860074655b1fc3c39bff7c7c4e
Subproject commit bb8846a3ab0dc92f31a343b7493ada533624a490