From ad241538b1818c5affc1bd99db0a1af6cd11f8f7 Mon Sep 17 00:00:00 2001 From: Dmitrii Shcherbakov Date: Wed, 31 May 2023 08:50:37 +0300 Subject: [PATCH] Update git submodules * Update charm-neutron-dynamic-routing from branch 'master' to b97646f6652ada059fb6416d94b8db5da42d9772 - Add OVN + neutron-dynamic-routing bundles * OVN + NDR testing is possible as of Neutron 22.0.0 (2023.1 or Antelope), see [1][2]. * Vault is added to non-OVN bundles as the tests.yaml file is shared and uses a configure step for Vault Important note: at the time of writing the OVN integration code in Neutron does not have any use for `distributed` and `ha` router extra attributes and whether distributed or centralized FIPs are used in OVN is governed by the ovn/enable_distributed_floating_ip option which does not operate at the per-router granularity and is global. The docs have not been updated and still say [3] that OVN routers do not expose `ha` or `distributed` attributes which are now there as of [1]. At the same time, the NDR implementation uses the `distributed` attribute to determine whether to use the gateway port IP and treat FIPs as centralized [4] and add a next-hop to the gateway port IP or not in the advertised /32 routes. For routers with `distributed == True`, NDR only attempts [5] to find ports with device owner `'floatingip_agent_gateway'`. Therefore, when distributed FIPs are enabled via ovn/enable_distributed_floating_ip, the `distributed` extra attribute on a router is set to `False` and /32 routes are advertised as centralized. The distributed FIP case is currently not exercised by the current bundles neither for ML2/ovs nor ML2/ovn. The current bundles only test the control plane and route advertisement, not packet forwarding via advertised next-hops. [1] https://review.opendev.org/c/openstack/neutron/+/864051 [2] https://github.com/openstack/neutron/commit/4d1a7bd0bc3b142a6dc7f8414ed0d30e6c159057 [3] https://github.com/openstack/neutron/blame/cd66232c2b26cb4141c2e9426ce2dec0f38c364c/doc/source/ovn/faq/index.rst#L16-L29 [4] https://github.com/openstack/neutron-dynamic-routing/blob/513ea649be9fd652b0c5b391167f851bc3d653bb/neutron_dynamic_routing/db/bgp_db.py#L564 [5] https://github.com/openstack/neutron-dynamic-routing/blob/513ea649be9fd652b0c5b391167f851bc3d653bb/neutron_dynamic_routing/db/bgp_db.py#L567-L580 Change-Id: I21ba5d79ff100b839874a65e4ddd32f20dfb1311 --- charm-neutron-dynamic-routing | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/charm-neutron-dynamic-routing b/charm-neutron-dynamic-routing index 5963ea4fc3..b97646f665 160000 --- a/charm-neutron-dynamic-routing +++ b/charm-neutron-dynamic-routing @@ -1 +1 @@ -Subproject commit 5963ea4fc32ef269d93f2fc8e05b363815397c43 +Subproject commit b97646f6652ada059fb6416d94b8db5da42d9772