openstack
/
openstack
Code Issues Proposed changes

Update git submodules 

* Update ansible-role-puppet from branch 'master'
  - Clear out old facts
    
    In debugging why I631e3e3592a9be5c7da642cf34eec6d9758bf161 was not
    rolling out to the zuul executors, I eventually found
    /etc/facter/facts.d/ansible.json was present on a number of hosts and
    effectively pinning the project-config checkout to an old reference.
    
    Given the dates around file creation and the pinned change number, it
    seems very likely something happened during the openstack->opendev
    transition where some hosts had ansible run with a specific
    project_config_ref set as a fact.  Although the fact is now unset,
    nothing will ever clear the old ansible.json which keeps applying.
    
    We could remove all stale files by hand; but a) it's not clear where
    it ran (although likely only hosts starting with z*) and b) we leave a
    chance for it to happen again.
    
    We could clear this after every puppet run; but it seems like this
    role should leave the system largely in the state it ran puppet in.
    
    Thus this clears out the file before the puppet run if no facts are
    given.  This should fix our immediate issue on all hosts.
    
    Change-Id: I96adf4fb77f06b18fe73b6f10d1b07b7fe44385f
This commit is contained in:
Ian Wienand 2019-05-29 13:51:35 +10:00 committed by Gerrit Code Review
parent 6b53c3a61d
commit da183c4762
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ansible-role-puppet

@ -1 +1 @@
Subproject commit 7a9fd23801a1c5251fbb0f10624867a338920e1f
Subproject commit e9fc2df1bc041ea174022553c8a90ed3b4bf6b0e