openstack
/
openstack
Code Issues Proposed changes

Update git submodules 

* Update charms.openstack from branch 'master'
  to df9a2eddecb9e68d27f0273e838ba010c64740a9
  - Use application_name by default for creating pools
    
    Charms consuming Ceph storage typically follow the convention that
    pools are named for the application rather than the service name. Most
    charms also allow for the pool name to be defined via a config option.
    Charms which inherit from the BaseOpenStackCephCharm class will not
    follow this typical behavior as the pool created is based on the charm
    name.
    
    This change updates the create_pool function to allow for a concrete
    charm to optionally provide the name of the pool to be created,
    defaulting to the application_name if one is not provided. This is a
    change in behavior as the previous behavior was to use the charm
    class's name property. Reviewing all known charms which inherit
    from/mixin the BaseOpenStackCephCharm reveals that Gnocchi is the only
    user of the create_pool method.
    
    As such, it stands to reason that a change in behavior is safe in this
    context since the charm class's name for gnocchi was set to the
    'gnocchi' which is also the typical application name.
    
    Change-Id: I1756ff4e1362fbc7584551249c583f8d3cb0c8dc
    Closes-Bug: #1918821
This commit is contained in:
Billy Olsen 2021-03-17 09:58:51 -07:00 committed by Gerrit Code Review
parent 9d46ae3a87
commit dc666b82af
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
charms.openstack

@ -1 +1 @@
Subproject commit 976dd86b833c592d4ec656eb3d42f143bf9e6569
Subproject commit df9a2eddecb9e68d27f0273e838ba010c64740a9