openstack
/
openstacksdk
Code Issues Proposed changes

Fix Magnum cluster update 

The only attribute can be updated is 'node_count' not 'name'[1]. This
patch fixes it.

[1] https://github.com/openstack/magnum/blob/master/magnum/api/validation.py#L32

Change-Id: Idb7578f63e688d9fdc85a8514d00ad03b99d8f83
This commit is contained in:
Feilong Wang 2018-07-10 10:59:19 +12:00
parent 66f3d14437
commit 38fafc7680
2 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
openstack/cloud/openstackcloud.py
View File

@ -8756,7 +8756,7 @@ class OpenStackCloud(_normalize.Normalizer):
return True
@_utils.valid_kwargs('name')
@_utils.valid_kwargs('node_count')
def update_coe_cluster(self, name_or_id, operation, **kwargs):
"""Update a COE cluster.

7
openstack/tests/unit/cloud/test_coe_clusters.py
View File

@ -146,8 +146,8 @@ class TestCOEClusters(base.TestCase):
validate=dict(
json=[{
u'op': u'replace',
u'path': u'/name',
u'value': u'new-coe-cluster'
u'path': u'/node_count',
u'value': 3
}]
)),
dict(
@ -157,7 +157,6 @@ class TestCOEClusters(base.TestCase):
# to be valid.
json=dict(clusters=[coe_cluster_obj.toDict()])),
])
new_name = 'new-coe-cluster'
self.cloud.update_coe_cluster(
coe_cluster_obj.uuid, 'replace', name=new_name)
coe_cluster_obj.uuid, 'replace', node_count=3)
self.assert_calls()